Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce GetSByte and GetSBytes to ArkArchive; handle sbyte and byte scenarios #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Introduce GetSByte and GetSBytes to ArkArchive; handle sbyte and byte scenarios #16

wants to merge 1 commit into from

Conversation

brcaswell
Copy link

relates to issue\bug #7

  • Adds GetSByte and GetSBytes methods to ArkArchive
  • Modify GetByte and GetBytes to return byte and byte[] in ArkArchive
  • Handle usages of GetByte based on expectation

Handled some refactor concepts with iterating and castings and introduce private CheckOverflow helper method in ArkArchive for code reuse and handling.

@brcaswell
add GetSByte and GetSBytes method to ArkArchive; modify sbyte to byte…
3b008d3 
… in ArkByteValue Type and ArkArrayByte ; implement BlockCopy for byte to sbyte conversion and remove both commented out code and unnecessary casts in ArkByteValue.cs; handle some sbyte[] scenarios that should be byte[] and ensure Int8 uses SByte.
@brcaswell brcaswell requested a review from tsebring February 18, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsebring tsebring Awaiting requested review from tsebring

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brcaswell