Fix msbc on Realtek USB adapters #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #638 +/- ##
==========================================
- Coverage 70.81% 70.76% -0.06%
==========================================
Files 48 48
Lines 8995 8999 +4
==========================================
- Hits 6370 6368 -2
- Misses 2625 2631 +6
☔ View full report in Codecov by Sentry. |
arkq
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables use of mSBC with Realtek USB adapters by applying a manufacturer-specific sco socket mtu value. This PR is a temporary measure until a more general mSBC over USB fix can be found (for example PR #550). See #637 for description of the problem being addressed.
Current BlueALSA sources result in silence being played, and bluealsa debug output shows
D: ../../src/hci.c:150: USB adjusted SCO MTU: 28: 24. With this PR, audio is played correctly and bluealsa debug output showsD: ../../src/hci.c:150: USB adjusted SCO MTU: 28: 72Fixes #637