Skip to content

Commit

Permalink
Automerge: Revert "Make llvm::telemetry::Manager::preDispatch protect…
Browse files Browse the repository at this point in the history
…ed. (#127114)"

This reverts commit f7a2d70.

Multiple buildbot failures have been reported.  See:
llvm/llvm-project#127114
  • Loading branch information
kazutakahirata authored and github-actions[bot] committed Feb 15, 2025
2 parents 6f1e329 + 66465c3 commit 84f6773
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 18 deletions.
9 changes: 4 additions & 5 deletions llvm/include/llvm/Telemetry/Telemetry.h
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,10 @@ class Manager {
public:
virtual ~Manager() = default;

// Optional callback for subclasses to perform additional tasks before
// dispatching to Destinations.
virtual Error preDispatch(TelemetryInfo *Entry) = 0;

// Dispatch Telemetry data to the Destination(s).
// The argument is non-const because the Manager may add or remove
// data from the entry.
Expand All @@ -146,11 +150,6 @@ class Manager {
// Register a Destination.
void addDestination(std::unique_ptr<Destination> Destination);

protected:
// Optional callback for subclasses to perform additional tasks before
// dispatching to Destinations.
virtual Error preDispatch(TelemetryInfo *Entry) {}

private:
std::vector<std::unique_ptr<Destination>> Destinations;
};
Expand Down
13 changes: 0 additions & 13 deletions llvm/lib/Telemetry/Telemetry.cpp
Original file line number Diff line number Diff line change
@@ -1,16 +1,3 @@
//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
///
/// \file
/// This file provides the basic framework for Telemetry.
/// Refer to its documentation at llvm/docs/Telemetry.rst for more details.
//===---------------------------------------------------------------------===//

#include "llvm/Telemetry/Telemetry.h"

namespace llvm {
Expand Down

0 comments on commit 84f6773

Please sign in to comment.