Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed forcefields to be class based #65

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Conversation

maximillian-dolan
Copy link
Contributor

We aspire to deal with all pull requests in a timely manner. Please be patient.

Ideally pull requests will respect the underlying intrastructure of pylj and agree with PEP8, etc. However, please do not let this put novice programmers off contributing.

@arm61
Copy link
Owner

arm61 commented Jun 17, 2024

Instead of having update_energy and update_force, I would have energy() and force() as methods that return the energy or the force.

Additionally, there is no docstring for the __init__, have a look at how to include these.

@arm61 arm61 merged commit d4395eb into arm61:master Jun 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants