Update RDF calculation sample.py #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed RDF calculation: the results were giving the wrong order of magnitude and the units of the equation were not correct. Added the lacking "2dr" for 2D-Simulations. Note: "len(system.distances)/(system.number_of_particles - 1)" is the same as "system.number_of_particles*0.5" but it was not clear to me where that came from.
|
Hi, I am currently working on the package. Just wondering if you can walk me through how the current method is wrong, and vice-versa how your's is right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed RDF calculation: the results were giving the wrong order of magnitude and the units of the equation were not correct.
Added the lacking "2dr" for 2D-Simulations.
Note: "len(system.distances)/(system.number_of_particles - 1)" is the same as "system.number_of_particles*0.5" but it was not clear to me where that came from.