Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Luckfox Core3566 ugly support or to not support at all #7295

Closed
1 task
buldo opened this issue Sep 24, 2024 · 7 comments
Closed
1 task
Labels
Feature Request Feature suggestion

Comments

@buldo
Copy link
Contributor

buldo commented Sep 24, 2024

Which feature would you like to have?

Hello, there is RK3566 compute module Luckfox Core3566. As I understand it co-branded in some way with Waveshare.
Manufacturer provides very bad sdk based on old kernel.

What I did:

  • take armbian config files and u-boot dts from radxa zero3 and modified it
  • added dts from Luckfox SDK kernel

This allows me to get working image for Luckfox Core3566( my board has no wifi module and emmc).

But patch soooo ugly so I don't know to do or not PR

armbian-core3566.patch

Can someone provide feedback about my patch?
P.S. I have no resources to refactor or support in long term

Funding

@buldo buldo added the Feature Request Feature suggestion label Sep 24, 2024
Copy link
Contributor

github-actions bot commented Sep 24, 2024

Jira ticket: AR-2500

@EvilOlaf
Copy link
Member

The dts files should go into armbian/linux-rockchip like this: armbian/linux-rockchip#245 and the rest into the build repo here.
Would be two individual PRs.

@buldo
Copy link
Contributor Author

buldo commented Oct 7, 2024

@EvilOlaf what about u-boot DTS?
In my branch radxa u-boot used and patched

@EvilOlaf
Copy link
Member

EvilOlaf commented Oct 8, 2024

@ceccocats
Copy link

Hi @buldo
I have a Core3566 (with wifi and emmc), i can help you testing.

@buldo buldo mentioned this issue Oct 8, 2024
8 tasks
@buldo
Copy link
Contributor Author

buldo commented Oct 8, 2024

@ceccocats I made PR #7354
I don't know is armbian CI for PR provides images or not. I can share image for SD card that I built earlier( if it allowed here to post links on mega)

@SuperKali
Copy link
Member

We can close this issue, the PR was merged on mainline #7354, to report an issue open a new issue, and the maintainer will check it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Feature suggestion
Development

No branches or pull requests

5 participants