-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arm64: dts: DTS for Luckfox Core3566 #254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, the CI fails as the file corresponding to the board dts is missing:
make[3]: *** No rule to make target 'arch/arm64/boot/dts/rockchip/rk3566-luckfox-core3566.dtb', needed by 'arch/arm64/boot/dts/rockchip/'. Stop.
make[3]: *** Waiting for unfinished jobs....
I suggest you review the dts, usually the ones provided by the vendor are not put together so well and are quite confusing, which leads you to rewrite them from 0.
Yeah and at least rename (or use a placeholder include) to adhere to the naming convention that exists in the directory. Also maybe just gather all includes in a single thing. |
@SuperKali I forgot most important dts. Added in the second commit. And one more question: |
I think they cannot be activated at the same time and one of them must be disabled
I usually recommend creating a single file and integrating an if function, although it would make sense to create an overlay for the latter |
@SuperKali will try to provide single dts after this weekend |
@SuperKali now dts is single file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, perfect!
* Device tree files from vendor SDK * core3566 files update * Luckfox core merged to single dts --------- Co-authored-by: SuperKali <[email protected]>
Device tree files from vendor SDK
Link to SDK https://drive.google.com/drive/folders/1q8zXpt3WzSfGyjJrTL8ObEmExVmXp-Ag
P.S. This files are aweful. But I have no enought knowledges to improve it.
P.P.S. Tested. Board works.
Related issue armbian/build#7295