-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new options to handle mirror selection better #3325
Conversation
- set to `github` to use mirror provided by GitHub, the same as `USE_GITHUB_UBOOT_MIRROR=yes`. - set to `gitee` to use mirror provided by Gitee, a Chinese git service. - leave it unset to use offical `source.denx.de`.
Thanks!
|
Yeah I checked those build options before coming up my own. Currently with my GitHub mirror option my build command is By "solved globally", do you mean to have another option like As for #2268 it should be fixed by #2703: Line 72 in b850bab
|
We have kernel, u-boot, firmware, rootfs cache mirrors that are (will be) tied to region (or China in particular). There are many way, even full automatic selection but IMO we don't need to go that far. Perhaps if choosing "china" it sets all above to their correct mirrors. Not each one separate. That. |
Alright. I'll still keep the individual options in case some mirror fails though (had one GitHub mirror out of quota this morning). |
OK, fair point. Then just add this option to the docs and we are ready to merge. |
You want to merge now or wait for me to get the GitHub mirror and that global option implemented to merge together? |
I'll wait. |
Usage similar to UBOOT_MIRROR.
Chinese users (the main user of mirror options) can have use this one instead of configure many different options.
@igorpecovnik ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
* Add new option UBOOT_MIRROR to select mainline U-Boot mirror - set to `github` to use mirror provided by GitHub, the same as `USE_GITHUB_UBOOT_MIRROR=yes`. - set to `gitee` to use mirror provided by Gitee, a Chinese git service. - leave it unset to use offical `source.denx.de`. * Add GITHUB_MIRROR option Usage similar to UBOOT_MIRROR. * Add REGIONAL_MIRROR option Chinese users (the main user of mirror options) can have use this one instead of configure many different options.
* Add new option UBOOT_MIRROR to select mainline U-Boot mirror - set to `github` to use mirror provided by GitHub, the same as `USE_GITHUB_UBOOT_MIRROR=yes`. - set to `gitee` to use mirror provided by Gitee, a Chinese git service. - leave it unset to use offical `source.denx.de`. * Add GITHUB_MIRROR option Usage similar to UBOOT_MIRROR. * Add REGIONAL_MIRROR option Chinese users (the main user of mirror options) can have use this one instead of configure many different options.
Description
Add new option UBOOT_MIRROR to select different mirror for U-Boot, similar to MAINLINE_MIRROR option. Added mainly to support a new Chinese mirror to speed up download.
github
to use mirror provided by Github, the same asUSE_GITHUB_UBOOT_MIRROR=yes
.gitee
to use mirror provided by Gitee, a Chinese git service.source.denx.de
.Additionally GITHUB_MIRROR option allows users to choose from fastgit, gitclone, and cnpmjs as their GitHub speed-up option.
Finally REGIONAL_MIRROR for Chinese user to set 4 mirror options at once. If user explicitly specifies a mirror then that one will be used instead.
How Has This Been Tested?
./compile.sh docker BOARD=radxa-zero BRANCH=current RELEASE=bullseye BUILD_MINIMAL=yes BUILD_DESKTOP=no KERNEL_ONLY=no KERNEL_CONFIGURE=no DOWNLOAD_MIRROR=china MAINLINE_MIRROR=tuna UBOOT_MIRROR=gitee GITHUB_MIRROR=fastgit
followed by:./compile.sh docker BOARD=radxa-zero BRANCH=current RELEASE=bullseye BUILD_MINIMAL=yes BUILD_DESKTOP=no KERNEL_ONLY=no KERNEL_CONFIGURE=no REGIONAL_MIRROR=china
Both completes without error.