Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker improvements and enabling auto testing #110

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Docker improvements and enabling auto testing #110

merged 4 commits into from
Sep 25, 2024

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Sep 24, 2024

Description

Rework Docker install and enable automated testing routine.

Implementation Details

Rework Docker install to use wget only. We don't need to use Curl and wget. When using BASH 4+ (which we do), we can use internal function to conduct lowercasing. Also improve purging by deleting the key and sources.

Testing Procedure

  • Auto testing enabled and successful

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have ensured that my changes do not introduce new warnings or errors
  • No new external dependencies are included
  • Changes have been tested and verified
  • I have included necessary metadata in the code, including associative arrays

@github-actions github-actions bot added size/small PR with less then 50 lines Scripts labels Sep 24, 2024
@igorpecovnik igorpecovnik force-pushed the docker branch 5 times, most recently from cd543f4 to 4ab94e2 Compare September 24, 2024 13:28
@igorpecovnik igorpecovnik changed the title Docker improvements and autotesting Docker improvements and enabling auto testing Sep 24, 2024
@igorpecovnik igorpecovnik added 11 Milestone: Fourth quarter release Needs review Seeking for review labels Sep 24, 2024
@schwar3kat schwar3kat added the Ready to merge Reviewed, tested and ready for merge label Sep 24, 2024
@Tearran Tearran merged commit 05296b1 into main Sep 25, 2024
25 of 42 checks passed
@Tearran Tearran deleted the docker branch September 25, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Needs review Seeking for review Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants