Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored json Software section to accommodate the growing number titles #111

Merged
merged 33 commits into from
Sep 25, 2024

Conversation

Tearran
Copy link
Member

@Tearran Tearran commented Sep 24, 2024

Description

This pull request refactors the JSON structure to better manage the growing number of titles, including addressing issue #98 regarding Cockpit. The sub-menu names can utilize unique IDs of descriptive names instead of , S00 or S0.1, enhancing clarity and usability.

Issue reference: #98
Related documentation: https://cockpit-project.org/

Implementation Details

  • Key changes introduced by this PR:

    • Added Cockpit
    • Added start and stop cockpit service
    • Refactored the JSON structure to replace unique IDs with descriptive names for sub-menus.
    • Enhanced readability and usability of the menu items.
  • Justification for the changes:

    • Using descriptive names helps users better understand the purpose of each sub-menu.
    • Reduces confusion caused by cryptic unique IDs.

Documentation Summary

Testing Procedure

  • Test 1: Verified that the new JSON structure loads correctly without errors.

  • Results: The application successfully initializes with the new menu structure, displaying all titles as expected.

  • Test 2: Checked that sub-menus function correctly and link to the appropriate content.

  • Results: All sub-menus operate as intended, and navigation works without issues.

Checklist

  • I have performed a self-review of my code.
  • I have ensured that my changes do not introduce new warnings or errors.
  • Changes have been tested and verified.

@Tearran Tearran linked an issue Sep 24, 2024 that may be closed by this pull request
@github-actions github-actions bot added size/large PR with 250 lines or more Scripts labels Sep 24, 2024
@igorpecovnik
Copy link
Member

Great job!

One thing. SW19. Should we move that somewhere else or even out? We should control updating packages list. Running automatically at start, unless it was updated like 10 minutes ago ... inside we update when additional repo is added, on demand.

@Tearran
Copy link
Member Author

Tearran commented Sep 24, 2024

from

./bin/armbian-configng --api see_current_apt
06:19:39"

to if > 10 min

./bin/armbian-configng --api see_current_apt
Update the package lists.

if < 10 min

./bin/armbian-configng --api see_current_apt
The package lists are up-to-date.

@Tearran Tearran added the Ready to merge Reviewed, tested and ready for merge label Sep 24, 2024
@Tearran
Copy link
Member Author

Tearran commented Sep 24, 2024

"./bin/armbian-configng --api see_current_apt update"

if < 10 min returns 0

if > 10 min

runs

apt_install_wrapper apt-get update

image

@Tearran Tearran removed the Ready to merge Reviewed, tested and ready for merge label Sep 25, 2024
@Tearran Tearran requested a review from schwar3kat September 25, 2024 04:22
@Tearran Tearran added the Needs review Seeking for review label Sep 25, 2024
@igorpecovnik igorpecovnik added 11 Milestone: Fourth quarter release Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Sep 25, 2024
@igorpecovnik igorpecovnik merged commit 569365c into main Sep 25, 2024
14 checks passed
@igorpecovnik igorpecovnik deleted the 98-add-cockpit-to-softy branch September 25, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cockpit to softy
2 participants