-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
118 task show menu location in the title box #121
Merged
igorpecovnik
merged 9 commits into
main
from
118-task-show-menu-location-in-the-title-box
Oct 6, 2024
Merged
118 task show menu location in the title box #121
igorpecovnik
merged 9 commits into
main
from
118-task-show-menu-location-in-the-title-box
Oct 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you go one menu lower, it should retain top section. SSH is example of this. Also i would propose to remove this status from BACKTITLE. Once is IMO enough. Lets keep this status place clean and ready for something else. |
Tearran
added
Discussion
Being discussed - Voice your opinions :)
and removed
Ready to merge
Reviewed, tested and ready for merge
labels
Sep 28, 2024
Tearran
commented
Sep 28, 2024
Tearran
commented
Sep 28, 2024
igorpecovnik
added
11
Milestone: Fourth quarter release
Ready to merge
Reviewed, tested and ready for merge
and removed
Needs review
Seeking for review
labels
Oct 3, 2024
igorpecovnik
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
11
Milestone: Fourth quarter release
Ready to merge
Reviewed, tested and ready for merge
size/small
PR with less then 50 lines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change updates the title of the dialog menu to include the
parent_id
, enhancing clarity for users by indicating the context of the current menu. This change addresses issue #118 by providing a clearer menu location reference within the title box.Motivation and Context:
The addition of the
parent_id
in the title allows users to easily identify the hierarchy of menus, improving usability and reducing confusion when navigating through multiple layers of options.Issue Reference:
Implementation Details
"$TITLE "
to"$TITLE ($parent_id)"
, which now displays the parent menu's identifier.examples
Testing Procedure
Test 1:
parent_id
included.parent_id
.Test 2:
Checklist