Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

118 task show menu location in the title box #121

Merged
merged 9 commits into from
Oct 6, 2024

Conversation

Tearran
Copy link
Member

@Tearran Tearran commented Sep 27, 2024

Description

This change updates the title of the dialog menu to include the parent_id, enhancing clarity for users by indicating the context of the current menu. This change addresses issue #118 by providing a clearer menu location reference within the title box.

Motivation and Context:
The addition of the parent_id in the title allows users to easily identify the hierarchy of menus, improving usability and reducing confusion when navigating through multiple layers of options.

Issue Reference:

Implementation Details

  • Key Changes Introduced by this PR:
    • Modified the title in the dialog menu from "$TITLE " to "$TITLE ($parent_id)", which now displays the parent menu's identifier.

examples

Testing Procedure

  • Test 1:

    • Description: Verified the dialog menu title displays correctly with the parent_id included.
    • Results: The title displayed as expected, confirming the inclusion of the parent_id.
  • Test 2:

    • Description: Navigated through multiple menu layers to ensure that the titles updated correctly in all instances.
    • Results: Titles in all menus showed the correct context, with no errors encountered during navigation.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have ensured that my changes do not introduce new warnings or errors
  • No new external dependencies are included
  • Changes have been tested and verified
  • I have included necessary metadata in the code, including associative arrays

@Tearran Tearran linked an issue Sep 27, 2024 that may be closed by this pull request
@github-actions github-actions bot added Scripts size/small PR with less then 50 lines labels Sep 27, 2024
@Tearran Tearran added the Ready to merge Reviewed, tested and ready for merge label Sep 27, 2024
@igorpecovnik
Copy link
Member

If you go one menu lower, it should retain top section. SSH is example of this. Also i would propose to remove this status from BACKTITLE. Once is IMO enough. Lets keep this status place clean and ready for something else.

@Tearran Tearran added Discussion Being discussed - Voice your opinions :) and removed Ready to merge Reviewed, tested and ready for merge labels Sep 28, 2024
@Tearran
Copy link
Member Author

Tearran commented Oct 2, 2024

Top/Main menu function

independent function
--backtitle = "$BACKTITLE" from set_runtime_variables
--title = "$TITLE" from set_runtime_variables
--menu = Menu "header/prompt" basic runtime from set_runtime_variables

image

Sub menu loop function

Also i would propose to remove this status from BACKTITLE. Once is IMO enough. Lets keep this status place clean and ready for something else.

--menu blank placeholder "$status" to be extended or replaced

Breadcrumbs placed in title

image

If you go one menu lower, it should retain top section.

2nd Breadcrumb in --title

image

@Tearran Tearran added the Needs review Seeking for review label Oct 2, 2024
@igorpecovnik igorpecovnik added 11 Milestone: Fourth quarter release Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Oct 3, 2024
@Tearran Tearran removed the Discussion Being discussed - Voice your opinions :) label Oct 3, 2024
@igorpecovnik igorpecovnik merged commit f347638 into main Oct 6, 2024
26 checks passed
@igorpecovnik igorpecovnik deleted the 118-task-show-menu-location-in-the-title-box branch October 6, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Show menu location in the title box
2 participants