Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

117 task Merge status and disabled into one functionality #122

Merged
merged 4 commits into from
Sep 30, 2024
Merged

117 task Merge status and disabled into one functionality #122

merged 4 commits into from
Sep 30, 2024

Conversation

Tearran
Copy link
Member

@Tearran Tearran commented Sep 27, 2024

"disabled": true,
select(.disabled|not) |

"status": "disabled"
select(.status != "disabled")

@Tearran Tearran linked an issue Sep 27, 2024 that may be closed by this pull request
[Task]: Merge status and disabled into one functionality #117
Closed
@github-actions github-actions bot added Scripts size/small PR with less then 50 lines size/medium PR with more then 50 and less then 250 lines and removed size/small PR with less then 50 lines labels Sep 27, 2024
@Tearran Tearran changed the title Update config.ng.functions.sh 117 task Merge status and disabled into one functionality Sep 27, 2024
@Tearran
Copy link
Member Author

Tearran commented Sep 27, 2024

This PR

"status": "disabled" # disables the menu list item

introduces

`"status": "preview"

changed to follow naming convention
"status": "Active" to "status": "active" to follow naming convention

@Tearran Tearran added Ready to merge Reviewed, tested and ready for merge Work in progress Unfinished / work in progress and removed Ready to merge Reviewed, tested and ready for merge Work in progress Unfinished / work in progress labels Sep 27, 2024
@github-actions github-actions bot added the Documentation Documentation changes or additions label Sep 30, 2024
@igorpecovnik igorpecovnik force-pushed the 117-task-merge-status-and-disabled-into-one-functionality branch from 39bd91c to ee3df45 Compare September 30, 2024 19:24
@igorpecovnik igorpecovnik force-pushed the 117-task-merge-status-and-disabled-into-one-functionality branch from ee3df45 to b448c27 Compare September 30, 2024 19:25
@igorpecovnik igorpecovnik merged commit 3c3acab into main Sep 30, 2024
6 checks passed
@igorpecovnik igorpecovnik deleted the 117-task-merge-status-and-disabled-into-one-functionality branch September 30, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik igorpecovnik left review comments

Assignees
No one assigned
Labels
Documentation Documentation changes or additions Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Merge status and disabled into one functionality
2 participants
@Tearran @igorpecovnik