Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split JSON into smaller parts + tools for its management #159

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

Tearran
Copy link
Member

@Tearran Tearran commented Oct 7, 2024

This PR adds tools. this tool splits the Jobs JSON file into smaller parts. prepares for future tools, such as moving documentation generation. No new dependencies are added.

Description

Implementation Details

  • Key Changes: Functions for splitting and joining JSON files.
  • Justification: Improves virstioning and sets up for future enhancements.
  • Dependencies: No new dependencies introduced.

Documentation Summary

  • Document include a simple help message -h

Testing Procedure

  • Test 1: Split a JSON file successfully.
  • Test 2: Joined multiple JSON files back into one.

Checklist

  • Follows style guidelines
  • Self-reviewed
  • No new warnings or errors
  • No new dependencies

@github-actions github-actions bot added size/large PR with 250 lines or more Scripts labels Oct 7, 2024
@github-actions github-actions bot added the Documentation Documentation changes or additions label Oct 7, 2024
@Tearran Tearran linked an issue Oct 7, 2024 that may be closed by this pull request
@igorpecovnik igorpecovnik added 11 Milestone: Fourth quarter release Needs review Seeking for review labels Oct 7, 2024
@igorpecovnik
Copy link
Member

Order of main menu is now different:

image

Also location of JSON files and scripts might need to be relocated.

@Tearran
Copy link
Member Author

Tearran commented Oct 7, 2024

Note: Main Goals here are to prove a place for..."

These are part of that and seem to justify adding the dev tools for future used to repo
Related:

Order of main menu is now different:

Added a sorting array/Map
Caveat: new (json files) such as "Other" or "Tweaks" have to be added to the Map
Bonus: Now can provide a template (json file) to test new menu items that will not be include in production

image

Also location of JSON files and scripts might need to be relocated.

The JSON files locations are trivial. Once location is decided or the why is known.

@igorpecovnik
Copy link
Member

The JSON files locations are trivial. Once location is decided or the why is known.

OK.

@igorpecovnik igorpecovnik removed the Needs review Seeking for review label Oct 7, 2024
@igorpecovnik igorpecovnik added the Ready to merge Reviewed, tested and ready for merge label Oct 7, 2024
@igorpecovnik igorpecovnik changed the title Tools management json Split JSON into smaller parts + tools for its management Oct 7, 2024
@igorpecovnik igorpecovnik merged commit 4202012 into main Oct 7, 2024
29 checks passed
@igorpecovnik igorpecovnik deleted the tools-management-json branch October 7, 2024 19:29
@igorpecovnik
Copy link
Member

This joining has to be made automatic at runtime. And removing it from lib/armbian-configng/as its confusing ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Documentation Documentation changes or additions Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Split json into main sections and put it into separate folder
2 participants