Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move change hostname function from JSON file #172

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Move change hostname function from JSON file #172

merged 2 commits into from
Oct 10, 2024

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Oct 10, 2024 •
edited
Loading

Description

Trivial change - adding a function instead of calling it directly from JSON.

Testing Procedure

  • Manual run

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have ensured that my changes do not introduce new warnings or errors
  • No new external dependencies are included
  • Changes have been tested and verified
  • I have included necessary metadata in the code, including associative arrays

@github-actions github-actions bot added Scripts size/small PR with less then 50 lines labels Oct 10, 2024
@igorpecovnik igorpecovnik added 11 Milestone: Fourth quarter release Ready to merge Reviewed, tested and ready for merge and removed size/small PR with less then 50 lines Scripts labels Oct 10, 2024
@github-actions github-actions bot added size/small PR with less then 50 lines Scripts labels Oct 10, 2024
@igorpecovnik igorpecovnik merged commit 01e4adb into main Oct 10, 2024
7 checks passed
@igorpecovnik igorpecovnik deleted the hostname branch October 10, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tearran Tearran Tearran approved these changes

Assignees
No one assigned
Labels
11 Milestone: Fourth quarter release Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorpecovnik @Tearran