Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktops: refactor desktop install, enable working ones, add unit tests #173

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Desktops: refactor desktop install, enable working ones, add unit tests #173

merged 2 commits into from
Oct 13, 2024

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Oct 11, 2024 •
edited
Loading

Description

Enabling well tested desktop variants, disable those we need to work more on. All enabled are covered with unit tests.

Implementation Details

Installing Armbian desktop packages + enabling respective login manager.

Testing Procedure

Odroid M1 hooked to the 1080p monitor

Armbian Jammy arm64

  • XFCE install / uninstall
  • Gnome install / uninstall
  • Cinnamon install / uninstall

Armbian Bookworm arm64

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have ensured that my changes do not introduce new warnings or errors
  • No new external dependencies are included
  • Changes have been tested and verified
  • I have included necessary metadata in the code, including associative arrays

@igorpecovnik igorpecovnik added the Work in progress Unfinished / work in progress label Oct 11, 2024
@github-actions github-actions bot added size/small PR with less then 50 lines Unit Tests labels Oct 11, 2024
@github-actions github-actions bot added size/large PR with 250 lines or more Scripts and removed size/small PR with less then 50 lines labels Oct 11, 2024
@igorpecovnik igorpecovnik force-pushed the desktop branch 23 times, most recently from 56c834e to 3098593 Compare October 11, 2024 15:08
@igorpecovnik igorpecovnik force-pushed the desktop branch 7 times, most recently from 480fd6f to dfc1172 Compare October 11, 2024 17:52
@igorpecovnik igorpecovnik mentioned this pull request Oct 11, 2024
Open
2 tasks
@igorpecovnik igorpecovnik force-pushed the desktop branch 4 times, most recently from 1dfa386 to 2003818 Compare October 11, 2024 18:47
@igorpecovnik igorpecovnik changed the title Desktops: enable unit tests Desktops: refactor desktop install, enable working ones, add unit tests Oct 11, 2024
@igorpecovnik igorpecovnik force-pushed the desktop branch 8 times, most recently from 96b4693 to 74d7fa1 Compare October 11, 2024 19:38
@igorpecovnik igorpecovnik added 11 Milestone: Fourth quarter release Needs review Seeking for review and removed Work in progress Unfinished / work in progress labels Oct 12, 2024
@Tearran Tearran merged commit d516c9f into main Oct 13, 2024
16 checks passed
@Tearran Tearran deleted the desktop branch October 13, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tearran Tearran Tearran approved these changes

Assignees
No one assigned
Labels
11 Milestone: Fourth quarter release GitHub Actions GitHub Actions code GitHub GitHub-related changes like labels, templates, ... Needs review Seeking for review size/large PR with 250 lines or more
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorpecovnik @Tearran