Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a warning to welcome screen #276

Merged
merged 13 commits into from
Dec 9, 2024

Conversation

Tearran
Copy link
Member

@Tearran Tearran commented Nov 29, 2024

Description

Added check_os_status compares /etc/armbian-distribution-status to os uses displays ok/exit window.
used the color module set_color 1

NOTE: manually changed /etc/armbian-distribution-status to bookworm= eos, tested, and csc for test.
Result

image

if = supported operates as normal

@Tearran Tearran linked an issue Nov 29, 2024 that may be closed by this pull request
@github-actions github-actions bot added the size/small PR with less then 50 lines label Nov 29, 2024
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines size/small PR with less then 50 lines and removed size/small PR with less then 50 lines size/medium PR with more then 50 and less then 250 lines labels Nov 29, 2024
@Tearran
Copy link
Member Author

Tearran commented Nov 29, 2024

image

to test commented out line for bookworm. /etc/armbian-distribution-status

@igorpecovnik
Copy link
Member

Yeah, something like that.

@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines size/small PR with less then 50 lines and removed size/small PR with less then 50 lines size/medium PR with more then 50 and less then 250 lines labels Nov 29, 2024
@igorpecovnik igorpecovnik force-pushed the 275-task-adding-a-warning-to-welcome-screen branch from 5243d4c to e2e93d8 Compare November 30, 2024 21:19
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines and removed size/small PR with less then 50 lines labels Nov 30, 2024
@igorpecovnik
Copy link
Member

Adjusted text a bit - check if it still sounds o.k.

Also there is some grep issue - on exit:

grep: : No such file or directory
User canceled. exiting

@Tearran
Copy link
Member Author

Tearran commented Dec 5, 2024

Removed file "/etc/armbian-distribution-status" to replicate message.

grep: : No such file or directory
User canceled. exiting

This is happening on an unsupported os or a modified os ( such as I did to test it ) That is aso unsupported as I understand. IMO Fixing this error seems a little counter productive.

@igorpecovnik
Copy link
Member

grep: : No such file or directory

I would suppress this error - we anyway show that conditions are not met with a big prompt.

@Tearran
Copy link
Member Author

Tearran commented Dec 6, 2024

@igorpecovnik redirected grep: : No such file or directory to null

If User canceled. exiting is issue, Would like to addressed separately. note: its is part of get_user_continue and process_input.

@igorpecovnik igorpecovnik added 02 Milestone: First quarter release Ready to merge Reviewed, tested and ready for merge labels Dec 6, 2024
@igorpecovnik igorpecovnik merged commit 4eba919 into main Dec 9, 2024
32 checks passed
@igorpecovnik igorpecovnik deleted the 275-task-adding-a-warning-to-welcome-screen branch December 9, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Adding a warning to welcome screen
2 participants