-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Odroid board selection #298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/medium
PR with more then 50 and less then 250 lines
label
Dec 2, 2024
igorpecovnik
requested changes
Dec 3, 2024
igorpecovnik
previously approved these changes
Dec 4, 2024
igorpecovnik
added
02
Milestone: First quarter release
Ready to merge
Reviewed, tested and ready for merge
labels
Dec 4, 2024
github-actions
bot
added
size/large
PR with 250 lines or more
Documentation
Documentation changes or additions
and removed
size/medium
PR with more then 50 and less then 250 lines
labels
Dec 4, 2024
Apologies for the commits and reverts. I didn't realise those commits would appear in the PR, consequently I reverted them. |
No worries. I think we are good to go at my last commit. Everyone had troubles with Git-Fu, if you struggle with this, I will do it in the morning. |
github-actions
bot
added
size/medium
PR with more then 50 and less then 250 lines
and removed
size/large
PR with 250 lines or more
labels
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
02
Milestone: First quarter release
Documentation
Documentation changes or additions
Ready to merge
Reviewed, tested and ready for merge
size/medium
PR with more then 50 and less then 250 lines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change provides a new dialog under system that will update or append
board_name=<xu4, xu3, xu3l, hc1>
to/boot/armbianEnv.txt
. It will also change theBOARD_NAME
value in/etc/armbian-release
.The option to do this will appear only if the board family is
odroidxu4
.The returns some functionality that was lost in the upgrade to
armbian-configng
.Issue reference: None.
Related documentation: None
Implementation Details
Key changes introduced by this PR
A new entry in
config.system.json
and a new file undertools/modules/system
.Justification for the changes
Returns lost functionality
Confirmation that no new external dependencies or modules have been introduced
Confirmed
Documentation Summary
[*] Metadata Included:
Did you include the metadata (associative arrays) in the code? Ensure that metadata for modules, jobs, and runtime has been updated appropriately.
The metadata is included, but I'm not sure I got this completely right.
Document Generated:
Did you generate the updated documentation using
armbian-configng --doc
? Confirm if the command was run to updateREADME.md
and provide any relevant details.There are no documentation changes.
Testing Procedure
Manually tested, conditions tested were:
Checklist