Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Odroid board selection #298

Merged
merged 8 commits into from
Dec 5, 2024
Merged

Add Odroid board selection #298

merged 8 commits into from
Dec 5, 2024

Conversation

GeoffClements
Copy link
Contributor

@GeoffClements GeoffClements commented Dec 2, 2024

Description

This change provides a new dialog under system that will update or append board_name=<xu4, xu3, xu3l, hc1> to /boot/armbianEnv.txt. It will also change the BOARD_NAME value in /etc/armbian-release.

The option to do this will appear only if the board family is odroidxu4.

The returns some functionality that was lost in the upgrade to armbian-configng.

Issue reference: None.
Related documentation: None

Implementation Details

  • Key changes introduced by this PR
    A new entry in config.system.json and a new file under tools/modules/system.

  • Justification for the changes
    Returns lost functionality

  • Confirmation that no new external dependencies or modules have been introduced
    Confirmed

Documentation Summary

  • [*] Metadata Included:
    Did you include the metadata (associative arrays) in the code? Ensure that metadata for modules, jobs, and runtime has been updated appropriately.
    The metadata is included, but I'm not sure I got this completely right.

  • Document Generated:
    Did you generate the updated documentation using armbian-configng --doc? Confirm if the command was run to update README.md and provide any relevant details.
    There are no documentation changes.

Testing Procedure

Manually tested, conditions tested were:

  • Correct line added when missing
  • Correct line added when already present
  • Ok and Cancel actions

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have ensured that my changes do not introduce new warnings or errors
  • No new external dependencies are included
  • Changes have been tested and verified
  • I have included necessary metadata in the code, including associative arrays

@github-actions github-actions bot added the size/medium PR with more then 50 and less then 250 lines label Dec 2, 2024
tools/modules/system/manage_odroid_board.sh Outdated Show resolved Hide resolved
tools/json/config.system.json Outdated Show resolved Hide resolved
tools/modules/system/manage_odroid_board.sh Show resolved Hide resolved
igorpecovnik
igorpecovnik previously approved these changes Dec 4, 2024
@igorpecovnik igorpecovnik added 02 Milestone: First quarter release Ready to merge Reviewed, tested and ready for merge labels Dec 4, 2024
@github-actions github-actions bot added size/large PR with 250 lines or more Documentation Documentation changes or additions and removed size/medium PR with more then 50 and less then 250 lines labels Dec 4, 2024
@GeoffClements
Copy link
Contributor Author

Apologies for the commits and reverts. I didn't realise those commits would appear in the PR, consequently I reverted them.

@igorpecovnik
Copy link
Member

igorpecovnik commented Dec 4, 2024

No worries. I think we are good to go at my last commit. Everyone had troubles with Git-Fu, if you struggle with this, I will do it in the morning.

@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines and removed size/large PR with 250 lines or more labels Dec 5, 2024
@igorpecovnik igorpecovnik merged commit 5c6dbb7 into armbian:main Dec 5, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release Documentation Documentation changes or additions Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants