Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply several fixes to NFS service #313

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Apply several fixes to NFS service #313

wants to merge 4 commits into from
+261 −26

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Dec 11, 2024 •
edited
Loading

Description

  • splitting client and server into separate modules
  • move client discovery to run_time
  • install nmap package if this module is used so we don't need to add this to dependency

Include fixes from #312

Testing Procedure

  • Install / remove
  • Enabling server, export folder, mount from remote
  • Discover servers in subnet, mounting to share

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have ensured that my changes do not introduce new warnings or errors
  • No new external dependencies are included
  • Changes have been tested and verified
  • I have included necessary metadata in the code, including associative arrays

@github-actions github-actions bot added the size/medium PR with more then 50 and less then 250 lines label Dec 11, 2024
@igorpecovnik igorpecovnik added the Work in progress Unfinished / work in progress label Dec 11, 2024
@igorpecovnik igorpecovnik force-pushed the nfsdfix branch 5 times, most recently from 835262b to 2035e06 Compare December 11, 2024 19:30
@github-actions github-actions bot added size/large PR with 250 lines or more and removed size/medium PR with more then 50 and less then 250 lines labels Dec 11, 2024
@igorpecovnik igorpecovnik force-pushed the nfsdfix branch 9 times, most recently from 5e336f0 to 39349b9 Compare December 11, 2024 20:05
@igorpecovnik igorpecovnik added Needs review Seeking for review and removed Work in progress Unfinished / work in progress labels Dec 11, 2024
@igorpecovnik igorpecovnik force-pushed the nfsdfix branch 2 times, most recently from 3b3cfec to 16dccd8 Compare December 11, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs review Seeking for review size/large PR with 250 lines or more
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorpecovnik @dimitry-ishenko