Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust module options to match recent changes #332

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Adjust module options to match recent changes #332

wants to merge 21 commits into from
+1,409 −808

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Dec 22, 2024 •
edited
Loading

Description

  • adjust many module options
  • add bridged networking for Docker instances
  • fix bugs on the way

Its a big merge but its manually tested. What could go wrong is misplaced media / include files for documentation as I have changed several IDs.

Testing Procedure

  • Manually testing each install

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have ensured that my changes do not introduce new warnings or errors
  • No new external dependencies are included
  • Changes have been tested and verified
  • I have included necessary metadata in the code, including associative arrays

@github-actions github-actions bot added the size/small PR with less then 50 lines label Dec 22, 2024
@igorpecovnik igorpecovnik force-pushed the module-fixes branch 6 times, most recently from 9c57a12 to 0ea186a Compare December 22, 2024 20:33
@igorpecovnik
Bazarr: adjust module options to match changes
01bbe3b 
- attach to custom docker bridge
- add purge option
@igorpecovnik
Deluge: adjust module options to match changes
28f5838 
- attach to custom docker bridge
- add purge option
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines and removed size/small PR with less then 50 lines labels Dec 23, 2024
@igorpecovnik igorpecovnik force-pushed the module-fixes branch 2 times, most recently from 4bee99a to 7a317ed Compare December 23, 2024 07:54
@github-actions github-actions bot added size/large PR with 250 lines or more and removed size/medium PR with more then 50 and less then 250 lines labels Dec 23, 2024
@igorpecovnik igorpecovnik force-pushed the module-fixes branch 3 times, most recently from e128fdf to 4371639 Compare December 23, 2024 08:41
@github-actions github-actions bot added the Documentation Documentation changes or additions label Dec 23, 2024
@igorpecovnik igorpecovnik force-pushed the module-fixes branch 5 times, most recently from 9ee888e to 3cdd95e Compare December 23, 2024 10:09
@github-actions github-actions bot added size/large PR with 250 lines or more Unit Tests labels Dec 24, 2024
@github-actions github-actions bot added size/small PR with less then 50 lines and removed size/large PR with 250 lines or more labels Dec 24, 2024
@igorpecovnik igorpecovnik force-pushed the module-fixes branch 20 times, most recently from ae36655 to 9c0f283 Compare December 24, 2024 20:32
@igorpecovnik igorpecovnik added Bugfix Pull request is fixing a bug Ready to merge Reviewed, tested and ready for merge and removed Work in progress Unfinished / work in progress labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tearran Tearran Tearran left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
02 Milestone: First quarter release Bugfix Pull request is fixing a bug Documentation Documentation changes or additions GitHub Actions GitHub Actions code GitHub GitHub-related changes like labels, templates, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines Unit Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorpecovnik @Tearran