Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up: #51

Closed
wants to merge 6 commits into from
Closed

clean up: #51

wants to merge 6 commits into from

Conversation

Tearran
Copy link
Member

@Tearran Tearran commented Sep 2, 2024

Description

  • Organized functions into appropriate files
  • Removed redundant and unused functions
  • Fixed jq error

Issue reference:

#49

Implementation Details

  • Fixed jq bug reporting a null at end of file
  • Confirmation that no new external dependencies or modules have been introduced

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have ensured that my changes do not introduce new warnings or errors
  • No new external dependencies are included
  • Changes have been tested and verified
  • I have included necessary metadata in the code, including associative arrays

@Tearran
Copy link
Member Author

Tearran commented Sep 2, 2024

From #49 made 2 helper functions from json so they may be accessible from the "--api" flag option
example

 sudo ./configng/bin/armbian-configng --api clear_google_authenticator

@Tearran Tearran requested a review from igorpecovnik September 2, 2024 19:55
@Tearran Tearran self-assigned this Sep 2, 2024
@Tearran Tearran mentioned this pull request Sep 2, 2024
Merged
4 tasks
igorpecovnik
igorpecovnik reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@igorpecovnik igorpecovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup.

lib/armbian-configng/config.ng.system.sh
sed -n -i '/password updating/{p;:a;N;/@include common-password/!ba;s/.*\\n/auth required pam_google_authenticator.so nullok\\nauth required pam_permit.so\\n/};p' /etc/pam.d/sshd

# Generate QR code if .google_authenticator file does not exist
[ ! -f /root/.google_authenticator ] && qr_code generate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to generate new code?

@Tearran Tearran marked this pull request as draft September 3, 2024 23:36
@Tearran Tearran added WIP and removed enhancement labels Sep 4, 2024
@Tearran Tearran changed the title clean up: Fixed jq error clean up: Sep 4, 2024
@Tearran Tearran closed this Sep 4, 2024
@Tearran Tearran deleted the cleanup branch September 4, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik igorpecovnik left review comments

Assignees

@Tearran Tearran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tearran @igorpecovnik