Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: Remove weird export restrictions #142

Closed

Conversation

simonswine
Copy link
Contributor

This prevents external file system (like ZFS for me) from being built, roughly automated creation of the changeset like this:

$ git ls-files | xargs ag -l ANDROID_GKI_VFS > files
$ cat files | xargs sed -i '/MODULE_IMPORT_NS(ANDROID_GKI_VFS_EXPORT_ONLY);/d' 
$ cat files | xargs sed -i 's/EXPORT_SYMBOL_NS(\(.*\), ANDROID_GKI_VFS_EXPORT_ONLY)/EXPORT_SYMBOL(\1)/g'

@amazingfate
Copy link
Collaborator

These are from an android commit: d483eed. What about reverting it?

@simonswine
Copy link
Contributor Author

These are from an android commit: d483eed. What about reverting it?

I imagined it would be harder to revert this, but I had not tried. Now used revert and a couple of manual clean-ups. Take another look please.

@simonswine simonswine force-pushed the 20240121_fix-exports-fs branch from 4592125 to 72402ed Compare January 21, 2024 17:19
@amazingfate
Copy link
Collaborator

Commit https://github.com/armbian/linux-rockchip/commit/d483eed85ffb9879b103cd8d6b3fae367fa6193e has modified 96 files, but your revert modifies 124 files, where does other files come from?

@Joshua-Riek
Copy link
Collaborator

I imagined it would be harder to revert this, but I had not tried. Now used revert and a couple of manual clean-ups. Take another look please.

I think they squashed a few changes into the revert commit. If this is the case I would create two commits, one to revert d483eed, then another for any other changes needed for ZFS to compile.

@amazingfate
Copy link
Collaborator

amazingfate commented Jan 22, 2024

First revert eff1ffb, then d483eed. I don't know if this will work.

bill88t pushed a commit to BredOS/linux-rockchip that referenced this pull request Feb 19, 2024
@amazingfate
Copy link
Collaborator

Close as lacking activity.

@amazingfate amazingfate closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants