Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64: dts: rockchip: add support for the Orange Pi 5 Pro #172

Merged
merged 3 commits into from
May 9, 2024

Conversation

Joshua-Riek
Copy link
Collaborator

@Joshua-Riek Joshua-Riek commented Apr 21, 2024

Introduce a device tree for the new Orange Pi 5 Pro.

Build system PR: armbian/build#6506

Cherry Picked from: orangepi-xunlong/linux-orangepi@d910e31

AR-2144

@efectn
Copy link
Member

efectn commented Apr 21, 2024

How similar are 5 and 5 pro devicetrees? Perhaps it would be cleaner if we include 5 devicetree and make the needed adjustments

@Joshua-Riek
Copy link
Collaborator Author

Let me take a closer look at the device trees, if we can just include the opi5 device tree that would be great.

@Joshua-Riek
Copy link
Collaborator Author

Hmm it does not look simple and would likely require some time digging through the whole OPI5 Pro device tree since what we have for the OPI5 is quite different.

For reference - Orange Pi 5 DTS are split into the following files:
https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi.dtsi
https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi
https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts

@efectn
Copy link
Member

efectn commented Apr 21, 2024

Hmm it does not look simple and would likely require some time digging through the whole OPI5 Pro device tree since what we have for the OPI5 is quite different.

For reference - Orange Pi 5 DTS are split into the following files: https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi.dtsi https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts

I don't really like current style. Are there any good reason that explains why Xunlong splits them into 3 files?

@Joshua-Riek
Copy link
Collaborator Author

Hmm it does not look simple and would likely require some time digging through the whole OPI5 Pro device tree since what we have for the OPI5 is quite different.
For reference - Orange Pi 5 DTS are split into the following files: https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi.dtsi https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts

I don't really like current style. Are there any good reason that explains why Xunlong splits them into 3 files?

I do not like it either and have found no explanation as to why Xunlong splits them into 3 files. I think the OPI5 device tree should be re-written, but it's not something I have the time for right now.

@efectn
Copy link
Member

efectn commented Apr 21, 2024

Hmm it does not look simple and would likely require some time digging through the whole OPI5 Pro device tree since what we have for the OPI5 is quite different.
For reference - Orange Pi 5 DTS are split into the following files: https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi.dtsi https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts

I don't really like current style. Are there any good reason that explains why Xunlong splits them into 3 files?

I do not like it either and have found no explanation as to why Xunlong splits them into 3 files. I think the OPI5 device tree should be re-written, but it's not something I have the time for right now.

Ok then no problem. I can take a look to refactor opi5 series devicetrees later

@igorpecovnik
Copy link
Member

can we sqeeze this into upcoming release?

@Joshua-Riek
Copy link
Collaborator Author

Sorry for delay, I'll fix this shortly, honestly forgot :P

@igorpecovnik
Copy link
Member

We are all crazy busy. no worries. Thanks!

@igorpecovnik igorpecovnik merged commit d601b05 into armbian:rk-5.10-rkr6 May 9, 2024
1 check failed
@igorpecovnik
Copy link
Member

Failing :(

@Joshua-Riek
Copy link
Collaborator Author

Oh, there was a typo in the LCD overlay, thanks for catching this in #179!

@Joshua-Riek Joshua-Riek deleted the opi5pro-5.10 branch June 4, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants