Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement point doubling for weierstrass curves #11

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

capito27
Copy link
Contributor

Quick, low hanging fruit for #10

Implement the exception free point doubling algorithm from the same source as the point addition algorithm.

It should be noted that on my system (Intel i7-7700k, Windows 10), criterion benchmarks were somewhat unconclusive, for P256, there was a 33% performance improvement with the doubling algorithm. For P384 however, there was a 30% performance degradation, whereas for p521, there was no difference.

As such, help with more in depth testing would be appreciated.

Also of note, adding a verification of equality when adding two points to instead call the point doubling function should they be equal (with both reference and inner field comparison) also produced unconclusive results, thus it was not added to the commit

PS : here is an archive containing the produced criterion graphs, should they be of use.
criterion_comparisons.zip

@armfazh armfazh self-requested a review June 22, 2020 20:47
@armfazh armfazh merged commit 6e0569d into armfazh:master Jun 22, 2020
@armfazh
Copy link
Owner

armfazh commented Jun 22, 2020

Thanks for your input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants