Merge pull request #88 from armosec/dev

Fix rolling update issues
armosec · Jul 20, 2022 · d4ae4d9 · d4ae4d9
2 parents 448008b + a904c8d
commit d4ae4d9
Show file tree

Hide file tree

Showing 7 changed files with 31 additions and 4 deletions.
diff --git a/charts/armo-components/Chart.yaml b/charts/armo-components/Chart.yaml
@@ -8,13 +8,13 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 1.7.14
+version: 1.7.15
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "v1.7.14"
+appVersion: "v1.7.15"
 
 maintainers:
 - name: Ben Hirschberg

diff --git a/.../templates/armo-collector-deployment.yaml → ...templates/armo-collector-statefulset.yaml b/.../templates/armo-collector-deployment.yaml → ...templates/armo-collector-statefulset.yaml
@@ -2,14 +2,17 @@
 {{ template "account_guid" . }}
 {{ template "cluster_name" . }}
 apiVersion: apps/v1
-kind: Deployment
+# statefulset is needed in order to avoid to pods reporting from the same cluster in parallel.
+# parallel reporting will cause Kubescape SaaS to miss identify the cluster liveness status
+kind: StatefulSet
 metadata:
   name: {{ .Values.armoCollector.name }}
   namespace: {{ .Values.armoNameSpace }}
   labels:
     app: {{ .Values.armoCollector.name }}
     tier: {{ .Values.global.namespaceTier}}
 spec:
+  serviceName: ""
   replicas: {{ .Values.armoCollector.replicaCount }}
   selector:
     matchLabels:

diff --git a/charts/armo-components/templates/armo-kubescape-deployment.yaml b/charts/armo-components/templates/armo-kubescape-deployment.yaml
@@ -11,6 +11,12 @@ metadata:
     helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}
 spec:
   replicas: {{ .Values.armoKubescape.replicaCount }}
+  revisionHistoryLimit: 2
+  strategy:
+    rollingUpdate:
+      maxSurge: 0%
+      maxUnavailable: 100%
+    type: RollingUpdate
   selector:
     matchLabels:
       app.kubernetes.io/name: {{ .Values.armoKubescape.name }}

diff --git a/charts/armo-components/templates/armo-notification-service-deployment.yaml b/charts/armo-components/templates/armo-notification-service-deployment.yaml
@@ -10,6 +10,12 @@ metadata:
     helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}
 spec:
   replicas: {{ .Values.armoNotificationService.replicaCount }}
+  revisionHistoryLimit: 2
+  strategy:
+    rollingUpdate:
+      maxSurge: 0%
+      maxUnavailable: 100%
+    type: RollingUpdate
   selector:
     matchLabels:
       app.kubernetes.io/name: {{ .Values.armoNotificationService.name }}

diff --git a/charts/armo-components/templates/armo-vuln-scanner-deployment.yaml b/charts/armo-components/templates/armo-vuln-scanner-deployment.yaml
@@ -11,6 +11,12 @@ metadata:
     tier: {{ .Values.global.namespaceTier}}
 spec:
   replicas: {{ .Values.armoVulnScanner.replicaCount }}
+  revisionHistoryLimit: 2
+  strategy:
+    rollingUpdate:
+      maxSurge: 0%
+      maxUnavailable: 100%
+    type: RollingUpdate
   selector:
     matchLabels:
       app.kubernetes.io/name: {{ .Values.armoVulnScanner.name }}

diff --git a/charts/armo-components/templates/armo-websocket-deployment.yaml b/charts/armo-components/templates/armo-websocket-deployment.yaml
@@ -9,6 +9,12 @@ metadata:
     tier: {{ .Values.global.namespaceTier}}
 spec:
   replicas: {{ .Values.armoWebsocket.replicaCount }}
+  revisionHistoryLimit: 2
+  strategy:
+    rollingUpdate:
+      maxSurge: 0%
+      maxUnavailable: 100%
+    type: RollingUpdate
   selector:
     matchLabels:
       app.kubernetes.io/name: {{ .Values.armoWebsocket.name }}

diff --git a/charts/armo-components/values.yaml b/charts/armo-components/values.yaml
@@ -217,7 +217,7 @@ armoWebsocket:
   image:
     # -- source code: https://github.com/armosec/k8s-ca-websocket (private repo)
     repository: quay.io/armosec/action-trigger
-    tag: v0.0.37
+    tag: v0.0.39
     pullPolicy: Always
 
   service: