Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove vuln_scan_trigger_scan_on_new_image system test #386

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

refaelm92
Copy link
Contributor

@refaelm92 refaelm92 commented May 29, 2024

PR Type

Enhancement, Tests


Description

  • Removed the vuln_scan_trigger_scan_on_new_image test case from the vuln_scan_tests.py file.
  • Updated multiple Jenkinsfiles to remove the vuln_scan_trigger_scan_on_new_image test from the test lists.

Changes walkthrough 📝

Relevant files
Tests
vuln_scan_tests.py
Remove `vuln_scan_trigger_scan_on_new_image` test case     

configurations/system/tests_cases/vuln_scan_tests.py

  • Removed the vuln_scan_trigger_scan_on_new_image test case.
+0/-12   
Enhancement
Jenkinsfile-helm-ks-be-test.groovy
Remove `vuln_scan_trigger_scan_on_new_image` from Jenkins test list

jenkins_files/Jenkinsfile-helm-ks-be-test.groovy

  • Removed the vuln_scan_trigger_scan_on_new_image test from the Jenkins
    test list.
  • +0/-1     
    Jenkinsfile-helm-ks-be.groovy
    Remove `vuln_scan_trigger_scan_on_new_image` from Jenkins test list

    jenkins_files/Jenkinsfile-helm-ks-be.groovy

  • Removed the vuln_scan_trigger_scan_on_new_image test from the Jenkins
    test list.
  • +0/-1     
    Jenkinsfile_helm_chart.groovy
    Remove `vuln_scan_trigger_scan_on_new_image` from Jenkins test list

    jenkins_files/Jenkinsfile_helm_chart.groovy

  • Removed the vuln_scan_trigger_scan_on_new_image test from the Jenkins
    test list.
  • +0/-1     
    Jenkinsfile_helm_chart_on_going_features.groovy
    Remove `vuln_scan_trigger_scan_on_new_image` from Jenkins test list

    jenkins_files/Jenkinsfile_helm_chart_on_going_features.groovy

  • Removed the vuln_scan_trigger_scan_on_new_image test from the Jenkins
    test list.
  • +0/-1     
    Jenkinsfile_payment.groovy
    Remove `vuln_scan_trigger_scan_on_new_image` from Jenkins test list

    jenkins_files/Jenkinsfile_payment.groovy

  • Removed the vuln_scan_trigger_scan_on_new_image test from the Jenkins
    test list.
  • +0/-1     
    Jenkinsfile_relevancy.groovy
    Remove `vuln_scan_trigger_scan_on_new_image` from Jenkins test list

    jenkins_files/Jenkinsfile_relevancy.groovy

  • Removed the vuln_scan_trigger_scan_on_new_image test from the Jenkins
    test list.
  • +0/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @codiumai-pr-agent-free codiumai-pr-agent-free bot added enhancement New feature or request Tests labels May 29, 2024
    Copy link

    PR Review 🔍

    ⏱️ Estimated effort to review [1-5]

    2, because the changes are straightforward and involve only the removal of a specific test case and its references in various Jenkinsfiles. The scope is limited and the modifications are repetitive across multiple files, making it easier to review.

    🧪 Relevant tests

    No

    ⚡ Possible issues

    Test Coverage Reduction: Removing a test case could potentially reduce the coverage and might miss catching regressions related to new image vulnerability scans unless adequately justified or replaced.

    🔒 Security concerns

    No

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for PR.

    Copy link

    Failed to generate code suggestions for PR

    @dwertent dwertent merged commit 75e4692 into master May 29, 2024
    3 checks passed
    @dwertent dwertent deleted the rem-test branch May 29, 2024 09:06
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants