Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update target repositories in system_test_mapping.json #396

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

kooomix
Copy link
Contributor

@kooomix kooomix commented Jun 25, 2024

PR Type

enhancement


Description

  • Updated target_repositories in system_test_mapping.json to include -dummy suffix for all entries.

Changes walkthrough 📝

Relevant files
Enhancement
system_test_mapping.json
Update target repositories with dummy suffix                         

system_test_mapping.json

  • Updated target_repositories values to include -dummy suffix.
+6/-6     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5] 1
🧪 Relevant tests No
🔒 Security concerns No
⚡ Key issues to review None

Copy link

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Maintainability
Add comments to clarify that the listed repositories are dummy repositories for testing purposes

It appears that the target repositories have been switched to dummy repositories. If this
change is intended for testing purposes only, it might be beneficial to add a comment or
metadata indicating that these are dummy repositories. This will help maintain clarity and
prevent confusion when others view or modify this file.

system_test_mapping.json [1478-1483]

 "target_repositories": [
-  "helm-chart-dummy",
-  "node-agent-dummy",
-  "storage-dummy",
-  "cadashboardbe-dummy",
-  "event-ingester-service-dummy",
-  "synchronizer-dummy"
+  "helm-chart-dummy",  // Dummy repository for testing
+  "node-agent-dummy",  // Dummy repository for testing
+  "storage-dummy",     // Dummy repository for testing
+  "cadashboardbe-dummy",  // Dummy repository for testing
+  "event-ingester-service-dummy",  // Dummy repository for testing
+  "synchronizer-dummy"  // Dummy repository for testing
 ]
 
Suggestion importance[1-10]: 8

Why: Adding comments to indicate that the repositories are dummy repositories for testing purposes improves code maintainability and clarity, helping prevent confusion for future maintainers.

8

Copy link

Failed to generate code suggestions for PR

@kooomix kooomix merged commit 2c2d5e0 into master Jun 25, 2024
3 checks passed
@matthyx matthyx deleted the disable_test branch August 22, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants