kdr_runtime_policies_configurations test #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed to generate code suggestions for PR |
|
Preparing PR description... |
|
Preparing review... |
Bezbran
reviewed
Aug 1, 2024
tests_scripts/runtime/policies.py
Outdated
| expected_incident_rulesets = TestUtil.get_expected_json(EXPECTED_RUNTIME_RULSETS_PATH) | ||
|
|
||
| try: | ||
| assert len(incident_rulesets["response"]) == len(expected_incident_rulesets["response"]), f"incident rulesets length is not equal, expected is {len(expected_incident_rulesets['response'])} but got {len(incident_rulesets['response'])}" |
There was a problem hiding this comment.
Both list of rulesets and list of default policies and list of incident types are about to grow.
are you sure you want the test to fail on those changes?
There was a problem hiding this comment.
@Bezbran I see - so checking length is greater than 0 would be enough?
Bezbran
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.