updating ac tests

[kooomix]

PR Type

enhancement, documentation

---

Description

• Renamed test functions in ks_microservice_test.py to improve clarity and reflect external workload tracking.
• Updated the README to ensure consistency with the new test function names.
• Modified system_test_mapping.json to use dummy repository names and align with the renamed test scenarios.

---

Changes walkthrough 📝

	Relevant files
Enhancement	ks_microservice_test.py Rename test functions for clarity and consistency                configurations/system/tests_cases/ks_microservice_test.py Renamed several test functions to reflect external workload tracking. Updated function names to improve clarity and consistency. +4/-4      system_test_mapping.json Update test mapping with new names and dummy repositories system_test_mapping.json Updated target repositories to use dummy names. Renamed test scenarios to match updated function names. +15/-15
Documentation	readme.md Update README with new test function names                              readme.md Updated test function names in the documentation table. Ensured consistency with the new function names. +4/-4

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-free]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Key issues to review Naming Consistency The new function names use 'workload_external_track' consistently, but 'ac_8_external_workload_with_cluster_takeover' doesn't follow this pattern. Incomplete Update Some target_repositories are updated to use '-dummy' suffix, but others are completely removed. This inconsistency might cause issues.

[github-actions]

Preparing PR description...

[codiumai-pr-agent-free]

PR Code Suggestions ✨

Category	Suggestion	Score
Enhancement	Add column headers to the table in the README file The table in the README file appears to be missing column headers. Adding headers would improve the clarity and readability of the information presented in the table. readme.md [65-68] -| `ac_5_fix_control_with_relevancy` | helm-chart | | in-cluster kubescape, backend | -| `ac_3_fix_control_no_relevancy` | helm-chart | | in-cluster kubescape, backend | -| `ac_3_fix_control_with_relevancy` | helm-chart | | in-cluster kubescape, backend | -| `ac_8_external_workload_with_cluster_takeover` | helm-chart | | in-cluster kubescape, backend | +| Test Name | Chart Type | Additional Info | Test Environment | +|-----------|------------|-----------------|-------------------| +| `ac_5_fix_control_with_relevancy` | helm-chart | | in-cluster kubescape, backend | +| `ac_3_fix_control_no_relevancy` | helm-chart | | in-cluster kubescape, backend | +| `ac_3_fix_control_with_relevancy` | helm-chart | | in-cluster kubescape, backend | +| `ac_8_external_workload_with_cluster_takeover` | helm-chart | | in-cluster kubescape, backend | Apply this suggestion Suggestion importance[1-10]: 8 Why: Adding column headers significantly improves the clarity and readability of the table, making it easier for users to understand the information presented.	8
Best practice	Improve the docstring by breaking it into clear, concise steps The docstring for the test method is quite long and contains run-on sentences. Consider breaking it down into shorter, more focused sentences for better readability and understanding of the test's purpose and steps. configurations/system/tests_cases/ks_microservice_test.py [62-66] """ -install scenario 'alpine' on the cluster, install the kubescape operator and run the scan. -once the attack chain has been detected on the backend, fix the attack chain and verify that is has been solved -by triggering a new image scan. +Test the attack chain detection and fix process: +1. Install 'alpine' scenario on the cluster. +2. Install the Kubescape operator and run the scan. +3. Detect the attack chain on the backend. +4. Fix the attack chain. +5. Verify the fix by triggering a new image scan. """ Apply this suggestion Suggestion importance[1-10]: 7 Why: Improving the docstring by breaking it into clear, concise steps enhances readability and understanding, which is beneficial for maintaining the code.	7
	Use a more descriptive suffix for test repositories in the JSON configuration The target repositories are being updated with "-dummy" suffixes. Ensure that this change is intentional and consistent across all relevant entries in the JSON file. If it's a temporary change for testing purposes, consider using a more descriptive suffix or adding a comment to explain the reason for this modification. system_test_mapping.json [582-585] "target_repositories": [ - "cadashboardbe-dummy", - "careportsreceiver-dummy", - "event-ingester-service-dummy", - "gateway-dummy" + "cadashboardbe-test", + "careportsreceiver-test", + "event-ingester-service-test", + "gateway-test" ], Apply this suggestion Suggestion importance[1-10]: 5 Why: The suggestion to use a more descriptive suffix for test repositories is a good practice for clarity, but it is not critical unless the change was unintentional or confusing. The suggestion to add a comment is also helpful for future maintainers.	5
Maintainability	Rename the test method to be more concise and descriptive Consider using a more descriptive name for the test method. The current name ac_alpine_workload_external_track_fix_image is quite long and doesn't clearly convey the purpose of the test. A more concise and descriptive name could improve readability and maintainability. configurations/system/tests_cases/ks_microservice_test.py [61-66] @staticmethod -def ac_alpine_workload_external_track_fix_image(): +def test_alpine_fix_image_scan(): """ - install scenario 'alpine' on the cluster, install the kubescape operator and run the scan. - once the attack chain has been detected on the backend, fix the attack chain and verify that is has been solved - by triggering a new image scan. + Install Alpine scenario, run Kubescape scan, detect attack chain, fix it, and verify solution with new image scan. + """ Apply this suggestion Suggestion importance[1-10]: 6 Why: The suggestion to rename the test method to a more concise and descriptive name improves readability and maintainability, but it is not crucial for functionality.	6

[github-actions]

Preparing review...