Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable workflows tests #524

Merged
merged 1 commit into from
Dec 9, 2024
Merged

enable workflows tests #524

merged 1 commit into from
Dec 9, 2024

Conversation

kooomix
Copy link
Contributor

@kooomix kooomix commented Dec 9, 2024

PR Type

enhancement


Description

  • Removed the '-dummy' suffix from target repository names in the system_test_mapping.json file.
  • Updated the repository names for workflows related to slack, teams, and jira notifications.
  • Ensures that the system test mapping reflects the correct repository names without dummy suffixes.

Changes walkthrough 📝

Relevant files
Enhancement
system_test_mapping.json
Update target repository names in system test mapping       

system_test_mapping.json

  • Removed the '-dummy' suffix from target repository names.
  • Updated repository names for slack, teams, and jira notifications
    workflows.
  • +12/-12 

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Change
    Verify that removing the '-dummy' suffix from repository names won't break existing system tests or integrations. Ensure these are the correct production repository names.

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Ensure consistent repository naming by removing all '-dummy' suffixes throughout the configuration file

    The PR shows inconsistency in the code hunks - while updating repository names to
    remove '-dummy' suffix, some code sections still reference
    'event-ingester-service-dummy'. This needs to be fixed to maintain consistency.

    system_test_mapping.json [1648]

    -"event-ingester-service-dummy"
    +"event-ingester-service"
      ],
      "description": "Checks workflows teams notifications",
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: The suggestion correctly identifies an inconsistency where some repository references still contain the '-dummy' suffix while others have had it removed. This inconsistency could cause integration issues and needs to be fixed to maintain proper configuration.

    9

    💡 Need additional feedback ? start a PR chat

    Copy link

    github-actions bot commented Dec 9, 2024

    Failed to generate code suggestions for PR

    @kooomix kooomix changed the title Update target repositories in system test mapping to remove dummy suffix enable workflows tests Dec 9, 2024
    @kooomix kooomix merged commit f784fe1 into master Dec 9, 2024
    3 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants