Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update system_test_mapping.json to skip workflows Jira notifications … #538

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

kooomix
Copy link
Contributor

@kooomix kooomix commented Dec 15, 2024

User description

…in staging and production environments


PR Type

Enhancement


Description

  • Updated environment settings for Jira notifications workflows to skip execution in specific environments:
    • staging
    • production
    • production-us
  • Removed unnecessary description field from the configuration
  • Maintains existing target repositories and ownership settings

Changes walkthrough 📝

Relevant files
Configuration changes
system_test_mapping.json
Configure environment-specific Jira notification workflow settings

system_test_mapping.json

  • Added environment restrictions for Jira notifications workflows
  • Set to skip on staging, production, and production-us environments
  • Removed redundant description field
  • +1/-2     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @kooomix kooomix merged commit 032e36e into master Dec 15, 2024
    3 checks passed
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Validation
    Verify that the comma-separated environment list format is properly handled by the system and that skipping these environments won't cause any unexpected side effects

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Convert comma-separated string to a proper JSON array for better data structure consistency and reliability

    Use an array format for environment names instead of comma-separated string to
    maintain consistency with JSON structure and prevent potential parsing issues.

    system_test_mapping.json [1675]

    -"skip_on_environment": "staging,production,production-us",
    +"skip_on_environment": ["staging", "production", "production-us"],
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: Using an array format instead of a comma-separated string is a better practice in JSON as it provides clearer structure, better type safety, and easier programmatic access. This change would improve code maintainability and reduce potential parsing errors.

    7

    Copy link

    Failed to generate code suggestions for PR

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant