Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system test mappings for various relevancy scenarios in JSON conf… #565

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

kooomix
Copy link
Contributor

@kooomix kooomix commented Jan 7, 2025

User description

…iguration


PR Type

Enhancement


Description

  • Added multiple new system test mappings for relevancy scenarios.

  • Defined specific targets and repositories for each mapping.

  • Assigned ownership for each mapping to [email protected].

  • Ensured consistent structure for all new mappings.


Changes walkthrough 📝

Relevant files
Enhancement
system_test_mapping.json
Add new relevancy scenario mappings                                           

system_test_mapping.json

  • Added new mappings for various relevancy scenarios.
  • Included targets and target repositories for each mapping.
  • Assigned ownership for each mapping.
  • Maintained consistent structure across all mappings.
  • +109/-0 

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Missing Descriptions

    All new test mappings have empty description fields. Descriptions should be added to document the purpose and expected behavior of each test scenario.

      "description": "",
      "skip_on_environment": "",
      "owner": "[email protected]"
    },
    "relevancy_java_and_python": {
      "target": [
        "In cluster",
        "Backend"
      ],
      "target_repositories": [
        "operator"
      ],
      "description": "",
      "skip_on_environment": "",
      "owner": "[email protected]"
    },
    "relevancy_java": {
      "target": [
        "In cluster",
        "Backend"
      ],
      "target_repositories": [
        "operator"
      ],
      "description": "",
      "skip_on_environment": "",
      "owner": "[email protected]"
    },
    "relevancy_golang": {
      "target": [
        "In cluster",
        "Backend"
      ],
      "target_repositories": [
        "operator"
      ],
      "description": "",
      "skip_on_environment": "",
      "owner": "[email protected]"
    },
    "relevancy_python": {
      "target": [
        "In cluster",
        "Backend"
      ],
      "target_repositories": [
        "operator"
      ],
      "description": "",
      "skip_on_environment": "",
      "owner": "[email protected]"
    },
    "relevancy_extra_large_image": {
      "target": [
        "In cluster",
        "Backend"
      ],
      "target_repositories": [
        "operator"
      ],
      "description": "",
      "skip_on_environment": "",
      "owner": "[email protected]"
    },
    "relevancy_large_image": {
      "target": [
        "In cluster",
        "Backend"
      ],
      "target_repositories": [
        "operator"
      ],
      "description": "",
      "skip_on_environment": "",
      "owner": "[email protected]"
    },
    "relevant_data_is_appended": {
      "target": [
        "In cluster",
        "Backend"
      ],
      "target_repositories": [
        "operator"
      ],
      "description": "",
      "skip_on_environment": "",
      "owner": "[email protected]"
    },
    "relevancy_enabled_stop_sniffing": {
      "target": [
        "In cluster",
        "Backend"
      ],
      "target_repositories": [
        "operator"
      ],
      "description": "",
      "skip_on_environment": "",
    Environment Validation

    The skip_on_environment field is empty for all mappings. Consider if any of these tests should be skipped in specific environments.

      "skip_on_environment": "",
      "owner": "[email protected]"
    },
    "relevancy_java_and_python": {
      "target": [
        "In cluster",
        "Backend"
      ],
      "target_repositories": [
        "operator"
      ],
      "description": "",
      "skip_on_environment": "",
      "owner": "[email protected]"
    },
    "relevancy_java": {
      "target": [
        "In cluster",
        "Backend"
      ],
      "target_repositories": [
        "operator"
      ],
      "description": "",
      "skip_on_environment": "",
      "owner": "[email protected]"
    },
    "relevancy_golang": {
      "target": [
        "In cluster",
        "Backend"
      ],
      "target_repositories": [
        "operator"
      ],
      "description": "",
      "skip_on_environment": "",
      "owner": "[email protected]"
    },
    "relevancy_python": {
      "target": [
        "In cluster",
        "Backend"
      ],
      "target_repositories": [
        "operator"
      ],
      "description": "",
      "skip_on_environment": "",
      "owner": "[email protected]"
    },
    "relevancy_extra_large_image": {
      "target": [
        "In cluster",
        "Backend"
      ],
      "target_repositories": [
        "operator"
      ],
      "description": "",
      "skip_on_environment": "",
      "owner": "[email protected]"
    },
    "relevancy_large_image": {
      "target": [
        "In cluster",
        "Backend"
      ],
      "target_repositories": [
        "operator"
      ],
      "description": "",
      "skip_on_environment": "",
      "owner": "[email protected]"
    },
    "relevant_data_is_appended": {
      "target": [
        "In cluster",
        "Backend"
      ],
      "target_repositories": [
        "operator"
      ],
      "description": "",
      "skip_on_environment": "",
      "owner": "[email protected]"
    },
    "relevancy_enabled_stop_sniffing": {
      "target": [
        "In cluster",
        "Backend"
      ],
      "target_repositories": [
        "operator"
      ],
      "description": "",
      "skip_on_environment": "",
      "owner": "[email protected]"

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Include validation criteria in test mappings to ensure proper test verification

    Consider adding validation criteria or expected outcomes in the test mappings to
    help verify test results.

    system_test_mapping.json [15-26]

     "relevancy_java_and_python": {
       "target": [
         "In cluster",
         "Backend"
       ],
       "target_repositories": [
         "operator"
       ],
       "description": "",
       "skip_on_environment": "",
    +  "validation_criteria": ["Java packages detected", "Python packages detected"],
       "owner": "[email protected]"
     }
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Adding validation criteria is a significant functional improvement that would help ensure test reliability and correctness by explicitly defining expected outcomes. This is a structural change that enhances test quality and verification capabilities.

    8

    Copy link

    github-actions bot commented Jan 7, 2025

    Failed to generate code suggestions for PR

    @kooomix kooomix merged commit 135e70c into master Jan 7, 2025
    3 checks passed
    @matthyx matthyx deleted the updatesysmap branch January 7, 2025 12:04
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants