update/docker-compose

arnavrneo · Mar 23, 2024 · 4c9d768 · 4c9d768
1 parent 5d37538
commit 4c9d768
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/url-shortener/frontend-servers/compose.yaml b/url-shortener/frontend-servers/compose.yaml
@@ -1,7 +1,6 @@
 services:
   frontend:
     image: d12758100786
-    container_name: frontend1
 #    build:
 #      context: ../frontend/
 #      dockerfile: Dockerfile
@@ -10,7 +9,7 @@ services:
 
   go-backend:
     image: 4b33b091a935
-    container_name: go
+    container_name: go # for referencing inside the other containers
 #    build:
 #      context: ../servers/go/
 #      dockerfile: Dockerfile
@@ -21,7 +20,7 @@ services:
 
   express-backend:
     image: feb890d9439b
-    container_name: express1
+    container_name: express
 #    build:
 #      context: ../servers/express-js/
 #      dockerfile: Dockerfile
@@ -37,5 +36,5 @@ services:
     ports:
       - "8080:80"
     depends_on:
-      - go-backend
+      - go-backend # cant use container name here
       - express-backend
diff --git a/url-shortener/servers/compose.yaml b/url-shortener/servers/compose.yaml
@@ -1,14 +1,14 @@
 services:
   go:
-    image: 4b33b091a935
+    image: 4b33b091a935 # replace with image/local-tagid
 #    build:
 #      context: go/
 #      dockerfile: Dockerfile
     ports:
       - "1234:1234"
 
   express:
-    image: feb890d9439b
+    image: feb890d9439b # replace with image/local-tagid
 #    build:
 #      context: express-js/
 #      dockerfile: Dockerfile

diff --git a/url-shortener/servers/proxy/urlShort.conf b/url-shortener/servers/proxy/urlShort.conf
@@ -1,7 +1,6 @@
 upstream backend {
-    least_conn;
     server go:1234;
-    server go:5678;
+    server express:5678;
 }
 
 server {