Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to decode links in Resource #21

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

JohnKuan
Copy link

@JohnKuan JohnKuan commented Nov 5, 2018

I have added support to parse links in Resource. I am not sure if this covers all cases but it seems to work on the updated DeserializerCollectionSpec test case.

@codecov-io
Copy link

Codecov Report

Merging #21 into master will decrease coverage by 0.07%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   90.15%   90.08%   -0.08%     
==========================================
  Files          31       31              
  Lines        2103     2128      +25     
==========================================
+ Hits         1896     1917      +21     
- Misses        207      211       +4
Impacted Files Coverage Δ
Vox/Core/Class/Context_Query.swift 89.28% <100%> (+0.47%) ⬆️
...ests/Deserializer/DeserializerCollectionSpec.swift 100% <100%> (ø) ⬆️
Vox/Core/Class/Resource.swift 84.03% <76.47%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76a35e4...6159956. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants