Add quarantine bucket feature #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexisVLRT
reviewed
Jun 6, 2023
cloud_function/main.py
Outdated
| logger = logging.Client().logger() | ||
|
|
||
|
|
||
| def move_object_to_quarantine(data, context): |
There was a problem hiding this comment.
Les commentaires sont un peu superflus ici, je pense que le code est auto-porteur
AlexisVLRT
reviewed
Jun 6, 2023
cloud_function/main.py
Outdated
| def move_object_to_quarantine(data, context): | ||
| data_json = json.loads(base64.b64decode(data["data"]).decode("utf-8")) | ||
|
|
||
| # Extract the bucket and object name from the event data |
There was a problem hiding this comment.
Suggested change
| # Extract the bucket and object name from the event data |
AlexisVLRT
requested changes
Jun 6, 2023
cloud_function/main.py
Outdated
| bucket_name = data_json["bucket"] | ||
| object_name = data_json["name"] | ||
|
|
||
| # Define the regex pattern for object name validation |
There was a problem hiding this comment.
Suggested change
| # Define the regex pattern for object name validation |
cloud_function/main.py
Outdated
| # Define the regex pattern for object name validation | ||
| regex_validation = os.environ["REGEX_VALIDATION"] | ||
|
|
||
| # # Initialize the Cloud Storage client |
There was a problem hiding this comment.
Suggested change
| # # Initialize the Cloud Storage client |
cloud_function/main.py
Outdated
| # # Initialize the Cloud Storage client | ||
| storage_client = storage.Client() | ||
|
|
||
| # # Get the object metadata |
There was a problem hiding this comment.
Suggested change
| # # Get the object metadata |
cloud_function/main.py
Outdated
| source_bucket = storage_client.get_bucket(bucket_name) | ||
| source_blob = source_bucket.blob(object_name) | ||
|
|
||
| # # Check if the object name matches the regex pattern |
There was a problem hiding this comment.
Suggested change
| # # Check if the object name matches the regex pattern |
cloud_function/main.py
Outdated
Comment on lines
30
to
36
| # Move the object to the quarantine bucket | ||
| quarantine_bucket_name = f"{bucket_name}-quarantine" | ||
| quarantine_bucket = storage_client.bucket(quarantine_bucket_name) | ||
| source_bucket.copy_blob(source_blob, quarantine_bucket, object_name) | ||
| source_blob.delete() | ||
|
|
||
| logger.warn(f"Object {object_name} moved to the quarantine bucket.") |
There was a problem hiding this comment.
Je pense que ce morceau là devrait être une fonction dédiée.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.