Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use real format types in data generator (#297) #298

Merged
merged 1 commit into from
May 8, 2024

Conversation

mcantelon
Copy link
Member

@mcantelon mcantelon commented Mar 19, 2024

Use real format types, read from a CSV file, in the fake data generation CLI tool. Allow the number of possible format types, from the CSV file, to be specified using a command-line option.

@mcantelon mcantelon force-pushed the dev/fake-format-data-improvement branch from 0d846a2 to af12c92 Compare March 19, 2024 07:23
@mcantelon mcantelon marked this pull request as draft March 19, 2024 07:25
@mcantelon mcantelon force-pushed the dev/fake-format-data-improvement branch 3 times, most recently from 63e0c79 to c372ec5 Compare March 19, 2024 07:56
@mcantelon mcantelon marked this pull request as ready for review March 19, 2024 19:34
@mcantelon mcantelon force-pushed the dev/fake-format-data-improvement branch from c372ec5 to b0eca0c Compare March 22, 2024 21:30
@mcantelon mcantelon force-pushed the dev/fake-format-data-improvement branch from b0eca0c to 42f7d0a Compare April 12, 2024 01:43
@mcantelon mcantelon force-pushed the dev/fake-format-data-improvement branch from 42f7d0a to da2dcea Compare May 1, 2024 04:17
Use real format types, read from a CSV file, in the fake data
generation CLI tool. Allow the number of possible format types, from
the CSV file, to be specified using a command-line option.
@mcantelon mcantelon force-pushed the dev/fake-format-data-improvement branch from da2dcea to cf4bbed Compare May 7, 2024 20:28
Copy link
Member

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mcantelon
Copy link
Member Author

Thanks @sevein !

@mcantelon mcantelon merged commit e26bf15 into main May 8, 2024
6 checks passed
@mcantelon mcantelon deleted the dev/fake-format-data-improvement branch May 8, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants