Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build binary when package version < 0.2 #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mamedin
Copy link
Contributor

@mamedin mamedin commented Feb 26, 2020

Acmetool v0.2 official packages are not available. This commits allows to
build the v0.2 binary from sources when acmetool package version < 0.2.

Connects to #17

Acmetool v0.2 official packages are not available. This commits allows to
build the v0.2 binary from sources.
@djjuhasz djjuhasz removed their request for review February 26, 2020 16:40
@djjuhasz
Copy link

I still think we should be using certbot and https://github.com/geerlingguy/ansible-role-certbot to deploy Let's Encrypt certificates.

@hakamine
Copy link
Member

I have the following concerns:

  • The added build tasks are not idempotent (the role will attempt to build the binary each time it is run on a server as it checks acmetool version from the installed package)
  • We will need to revert the changes made by this PR when the acmetool maintainers release the packages for v0.2
  • It adds a golang build environment to the target server

I was wondering if we could just add a note to the README, with instructions on how to build the binary (e.g., here), mentioning this is a required temporary workaround until the acmetool maintainers release the packages for the new version (and also that the package needs to be built only once and then copied to any server as required, no need to build several times on each server)

@luisilara
Copy link

luisilara commented Feb 27, 2020

I like the idea of using certbot, but this fix also LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants