Add an integration test #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
===========================================
+ Coverage 29.31% 48.85% +19.54%
===========================================
Files 6 6
Lines 174 174
===========================================
+ Hits 51 85 +34
+ Misses 118 82 -36
- Partials 5 7 +2 ☔ View full report in Codecov by Sentry. |
sevein
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Nice! Something I would include is a check to t.Skip the test unless an environment string is provided by the user. It's nice to have the ability to run quick tests only, e.g. tests that take milliseconds as opposed to seconds.
https://peter.bourgon.org/blog/2021/04/02/dont-use-build-tags-for-integration-tests.html
Add an integration test that removes a .DS_Store file from a transfer.
djjuhasz
force-pushed
the
dev/integration-test
branch
from
d8244b3 to
55b5778
Compare
Only run integration tests when ENDURO_PP_INTEGRATION_TEST is "true" to avoid slow running (>1s) tests when they aren't necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration test removing a ".DS_Store" file from a transfer in pre-processing.