Use new version of removefiles activity #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It removes the possibility to change the filenames to be removed through worker configuration.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 47.75% 48.61% +0.86%
==========================================
Files 6 6
Lines 178 181 +3
==========================================
+ Hits 85 88 +3
Misses 86 86
Partials 7 7 ☔ View full report in Codecov by Sentry. |
|
@djjuhasz I decided to remove the possibility to make this configurable for now, we can figure out later if it's really needed and deal with the separator, unmarshalling, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It removes the possibility to change the filenames to be removed through worker configuration.
Refs artefactual-sdps/temporal-activities#12.