Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace remove files activity #9

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

djjuhasz
Copy link
Contributor

@djjuhasz djjuhasz commented Apr 16, 2024

Replace "github.com/artefactual-sdps/remove-files-activity" with "github.com/artefactual-sdps/temporal-activities/removefiles".

Also:

  • Remove example ".remove" and ".succumb" files
  • Remove creation of ".remove" file from kube dev overlay
  • Add unit tests for the preprocessing workflow

@djjuhasz
Copy link
Contributor Author

Waiting on artefactual-sdps/temporal-activities#7 being merged to allow setting RemoveNames from a config value.

Copy link

codecov bot commented Apr 16, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@djjuhasz djjuhasz force-pushed the dev/replace-remove-files-activity branch 2 times, most recently from 06b902e to 68f18da Compare April 19, 2024 00:45
@djjuhasz djjuhasz marked this pull request as ready for review April 19, 2024 00:49
@djjuhasz djjuhasz changed the title WIP: Replace remove files activity Replace remove files activity Apr 19, 2024
@djjuhasz djjuhasz requested a review from jraddaoui April 19, 2024 00:50
@djjuhasz djjuhasz force-pushed the dev/replace-remove-files-activity branch from 68f18da to 21eb86d Compare April 19, 2024 00:51
Copy link
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

hack/kube/overlays/dev/preprocessing-moma-secret.yaml Outdated Show resolved Hide resolved
internal/config/config_test.go Outdated Show resolved Hide resolved
Fixes #1

Replace "github.com/artefactual-sdps/remove-files-activity" with
"github.com/artefactual-sdps/temporal-activities/removefiles".

Also:
- Remove example ".remove" and ".succumb" files
- Remove creation of ".remove" file from kube dev overlay
@djjuhasz djjuhasz force-pushed the dev/replace-remove-files-activity branch from 21eb86d to 8f7ed8a Compare April 19, 2024 15:50
@djjuhasz djjuhasz merged commit 905b99e into main Apr 19, 2024
9 checks passed
@djjuhasz djjuhasz deleted the dev/replace-remove-files-activity branch April 19, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants