Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even numbers #10

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Even numbers #10

wants to merge 5 commits into from

Conversation

artemiipatov
Copy link
Owner

Proposed Changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Homeworks-sem4?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

let checkCorrectness func (count: uint) =
let isEven n = (n % 2 = 0)

let countEvenNumbers list =

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Очень нехорошо так делать — тестировать алгоритм путем сравнения с некоторым другим, написанным в тестах якобы эталонным алгоритмом.

Во-первых, если вам нужно будет поменять алгоритм, придется переписывать и тестовый алгоритм.
Во-вторых, "эталонный" алгоритм также может содержать ошибки, поскольку эталонный алгоритм не протестирован.
В-третьих, если тест упадет, диагностика и выяснение виноватых займет больше времени, чем требуется.

Поэтому лучше использовать классический подход: проверку конкретного результата выполнения функции на конкретных аргументах

myFunc [1; -1; 0; 2] |> should be 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants