Game #11
Open
Game #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion of cursor depends of variable, which value sets manually
yurii-litvinov
suggested changes
Jun 1, 2022
| @@ -0,0 +1,29 @@ | |||
| namespace ConsoleWrapper; | |||
|
|
|||
| public class ConsoleWrapper : IConsoleWrapper | |||
Comment on lines
5
to
8
| public void WriteLine(string data) | ||
| { | ||
| Console.WriteLine(data); | ||
| } |
There was a problem hiding this comment.
Suggested change
| public void WriteLine(string data) | |
| { | |
| Console.WriteLine(data); | |
| } | |
| public void WriteLine(string data) | |
| => Console.WriteLine(data); |
Делегация же.
| @@ -0,0 +1,9 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
И это не должно быть отдельным проектом :)
Game/Game/EventLoop.cs
Outdated
| /// <summary> | ||
| /// Starts the event loop | ||
| /// </summary> | ||
| /// <exception cref="ArgumentOutOfRangeException"></exception> |
There was a problem hiding this comment.
Комментарии ко всему классу и его public event-ам нужны, а пустые тэги — нет
| Position = (Position.Item1, Position.Item2 + 1); | ||
| console.SetCursorPosition(Position.Item1, Position.Item2); | ||
| WriteAtSign(); | ||
| } |
There was a problem hiding this comment.
Копипаст. Можно реализовать логику один раз, просто передавать ей разное изменение позиции
| using Game; | ||
| using IConsoleWrapper = ConsoleWrapper.IConsoleWrapper; | ||
|
|
||
| IConsoleWrapper console = new ConsoleWrapper.ConsoleWrapper(); |
There was a problem hiding this comment.
Suggested change
| IConsoleWrapper console = new ConsoleWrapper.ConsoleWrapper(); | |
| var console = new ConsoleWrapper.ConsoleWrapper(); |
Вам тут не важно, что это именно интерфейс, он при вызове Game.Game(console) сам скастается
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.