Priority Queue #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+15
to
+21
| for (var i = 0; i < 10; i++) | ||
| { | ||
| var priority = i; | ||
| tasks[i] = Task.Run(() => EnqueueValues(priority)); | ||
| } | ||
|
|
||
| Task.WaitAll(tasks); |
There was a problem hiding this comment.
Это ведь SetUp, тут можно было просто последовательно значения в очередь сложить, и иметь отдельный тест на гонки при добавлении. Иначе независимость тестов нарушается
| { | ||
| lock (_queueElementList) | ||
| { | ||
| while (Size == 0) |
There was a problem hiding this comment.
Кажется, Size лучше быть volatile-полем, потому что этот поток может ещё не увидеть изменений из 28-й строки и снова встанет на Wait — дедлок. В .NET memory model вроде есть что-то про то, что взятие/освобождение замка влечёт синхронизацию памяти, так что на практике, скорее всего, всё будет хорошо, но мне кажется, лучше избегать таких проблем явно.
| /// Class for elements of the queue. | ||
| /// </summary> | ||
| /// <typeparam name="TValue">Elements value type.</typeparam> | ||
| private class QueueElement<TValue> : IComparable<QueueElement<TValue>> |
There was a problem hiding this comment.
Линтер по делу ругается, тут лишний параметр-тип
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.