Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update codebase to support fastapi>=0.100.0 and pydantic>=2.0.0 #447
update codebase to support fastapi>=0.100.0 and pydantic>=2.0.0 #447
Changes from 1 commit
6a09192
f234e0d
43268a7
742accd
5bc801b
d5618bd
c457b97
9449e25
4af4450
30f4c3b
3174131
bf7e5c2
b1f8c0d
73baabe
5551a2a
e76051a
94c45f2
eadbac0
cf2473b
35ff5ae
d8406fa
0f1c161
a267eea
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should raise an exception for now until we figure this out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left the comment here for future as a note that union of
list
type with other types is not supported just in case someone thought that for example type likelist[str] | int | None
should work with filter. At the same time I don't think that it is reasonable to support such types ( I mean transformation oflist
part tostr
split by comma in such complex types) without knowing real usecase. Also supporting such types would be problem in case of types likelist[str] | str | None
.Raising exception here is not a good idea because the exception would be raised on any type which is union basically so for example
int | float
because this is union type and will have length 2 but at the same time it is valid type which we want to skip. Maybe I should just update comment to specifically mention that I am not sure what to do if the type is combination oflist
and other types likelist[str] | str
? Because list filtering will not work in that case 🤔What do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnybx Do you have time to make that change or do you want me to do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arthurio sure I just wasn't sure if you are fine with what I wrote. I added note to code and also added small section about current limitations of union types in filters with list. Let me know if something should be changed 👍