Skip to content

Commit

Permalink
scripts : verify py deps at the start of compare (ggerganov#9520)
Browse files Browse the repository at this point in the history
  • Loading branch information
ggerganov authored and arthw committed Nov 15, 2024
1 parent 25a2012 commit 0df4314
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
3 changes: 3 additions & 0 deletions scripts/compare-commits.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ fi
set -e
set -x

# verify at the start that the compare script has all the necessary dependencies installed
./scripts/compare-llama-bench.py --check

bench_args="${@:3}"

rm -f llama-bench.sqlite > /dev/null
Expand Down
5 changes: 5 additions & 0 deletions scripts/compare-llama-bench.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,18 @@
"If the columns are manually specified, then the results for each unique combination of the "
"specified values are averaged WITHOUT weighing by the --repetitions parameter of llama-bench."
)
parser.add_argument("--check", action="store_true", help="check if all required Python libraries are installed")
parser.add_argument("-s", "--show", help=help_s)
parser.add_argument("--verbose", action="store_true", help="increase output verbosity")

known_args, unknown_args = parser.parse_known_args()

logging.basicConfig(level=logging.DEBUG if known_args.verbose else logging.INFO)

if known_args.check:
# Check if all required Python libraries are installed. Would have failed earlier if not.
sys.exit(0)

if unknown_args:
logger.error(f"Received unknown args: {unknown_args}.\n")
parser.print_help()
Expand Down

0 comments on commit 0df4314

Please sign in to comment.