grammar-parser : fix possible null-deref (ggerganov#9004)

Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=70680 Signed-off-by: David Korczynski <[email protected]>
arthw · Nov 18, 2024 · c8f179c · c8f179c
1 parent 1b608cb
commit c8f179c
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/common/grammar-parser.cpp b/common/grammar-parser.cpp
@@ -369,6 +369,9 @@ namespace grammar_parser {
             }
             // Validate the state to ensure that all rules are defined
             for (const auto & rule : state.rules) {
+                if (rule.empty()) {
+                    throw std::runtime_error("Undefined rule");
+                }
                 for (const auto & elem : rule) {
                     if (elem.type == LLAMA_GRETYPE_RULE_REF) {
                         // Ensure that the rule at that location exists