! Patching MySQL's lack of support for filter conditions

artiomchi · May 21, 2019 · 752d529 · 752d529
1 parent 3ceeff1
commit 752d529
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/src/FlexLabs.EntityFrameworkCore.Upsert/Runners/MySqlUpsertCommandRunner.cs b/src/FlexLabs.EntityFrameworkCore.Upsert/Runners/MySqlUpsertCommandRunner.cs
@@ -38,13 +38,9 @@ public override string GenerateCommand(string tableName, ICollection<ICollection
             {
                 result.Append(" ON DUPLICATE KEY UPDATE ");
                 result.Append(string.Join(", ", updateExpressions
-                    .Select((e, i) =>
-                    {
-                        var statement = $"{EscapeName(e.ColumnName)} = {ExpandValue(e.Value)}";
-                        if (updateCondition != null)
-                            statement = $"IF ({ExpandExpression(updateCondition)}, {statement}, {EscapeName(e.ColumnName)})";
-                        return statement;
-                    })));
+                    .Select((e, i) => updateCondition != null
+                        ? $"{EscapeName(e.ColumnName)} = IF ({ExpandExpression(updateCondition)}, {ExpandValue(e.Value)}, {EscapeName(e.ColumnName)})"
+                        : $"{EscapeName(e.ColumnName)} = {ExpandValue(e.Value)}")));
             }
             return result.ToString();
         }