-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added Linux Mint Support #515
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artis3n
requested changes
Nov 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting this PR!
In order to add a new supported distro, the following additional steps need to be added:
- Update Galaxy metadata (https://github.com/artis3n/ansible-role-tailscale/blob/main/meta/main.yml#L11)
- Build a testable Molecule container for the distro (e.g. https://github.com/geerlingguy/docker-ubuntu2404-ansible and https://github.com/artis3n/docker-rhel9-ansible)
- Ensure the test suite runs successfully on the container (https://github.com/artis3n/ansible-role-tailscale?tab=readme-ov-file#development-and-contributing) (
MOLECULE_DISTRO=your-distro-here make test-all
) - Add the container to the CI suite (https://github.com/artis3n/ansible-role-tailscale/blob/main/.github/workflows/pull_request_target.yml#L26)
artis3n
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Linux Mint support.
Following Problems induced changes:
the codename for
name: Debian | Add Tailscale Deb
would point towilma
but it should benoble
(viriginia
->jammy
, etc. respectively)Solution:
tailscale_debian_release
, that replaces sub distro codenames to parent distro code names.codename
when callingansible.builtin.apt_repository
, but only if the codename has to be overriddenLinux Mint was not among the list of supported operating systems
Solution: added entries for Linux Mint at
tailscale_debian_family_distros
URLs would include
linux mint
orwilma
instead ofubuntu
andnoble
(e.g.https://pkgs.tailscale.com/stable/linux mint/wilma.noarmor.gpg
instead ofhttps://pkgs.tailscale.com/stable/ubuntu/noble.noarmor.gpg
)Solution:
tailscale_debian_distro
tailscale_debian_distro
with automatic fallback toansible_distribution
Currently supported:
Tested on:
Closes #516