Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Linux Mint Support #515

Merged
merged 8 commits into from
Dec 13, 2024
Merged

Conversation

fkonradmain
Copy link
Contributor

@fkonradmain fkonradmain commented Nov 16, 2024

Added Linux Mint support.

Following Problems induced changes:

  1. the codename for name: Debian | Add Tailscale Deb would point to wilma but it should be noble (viriginia -> jammy, etc. respectively)
    Solution:

    • introduction of a mapping dict tailscale_debian_release, that replaces sub distro codenames to parent distro code names.
    • added Value for codename when calling ansible.builtin.apt_repository, but only if the codename has to be overridden
  2. Linux Mint was not among the list of supported operating systems
    Solution: added entries for Linux Mint at tailscale_debian_family_distros

  3. URLs would include linux mint or wilma instead of ubuntu and noble (e.g. https://pkgs.tailscale.com/stable/linux mint/wilma.noarmor.gpg instead of https://pkgs.tailscale.com/stable/ubuntu/noble.noarmor.gpg)
    Solution:

    • also added entries for Linux mint at tailscale_debian_distro
    • added functionality to actually look up table values from tailscale_debian_distro with automatic fallback to ansible_distribution

Currently supported:

  • Linux Mint 22

Tested on:

  • Linux Mint 22
  • Debian 12

Closes #516

Copy link
Owner

@artis3n artis3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this PR!

In order to add a new supported distro, the following additional steps need to be added:

  1. Update Galaxy metadata (https://github.com/artis3n/ansible-role-tailscale/blob/main/meta/main.yml#L11)
  2. Build a testable Molecule container for the distro (e.g. https://github.com/geerlingguy/docker-ubuntu2404-ansible and https://github.com/artis3n/docker-rhel9-ansible)
  3. Ensure the test suite runs successfully on the container (https://github.com/artis3n/ansible-role-tailscale?tab=readme-ov-file#development-and-contributing) (MOLECULE_DISTRO=your-distro-here make test-all)
  4. Add the container to the CI suite (https://github.com/artis3n/ansible-role-tailscale/blob/main/.github/workflows/pull_request_target.yml#L26)

vars/main.yml Outdated Show resolved Hide resolved
@artis3n artis3n merged commit d769661 into artis3n:main Dec 13, 2024
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Linux Mint support
2 participants