Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: phone input component #10420

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

MounirDhahri
Copy link
Member

This PR resolves []

Description

This PR updates the phone input component to use proper masking and fixes the old slow/broken experience.

Changes made:

  • Update the list of phone countries and phone numbers to a more up to date one
  • Allow multiple masks per country
  • Fix performance issues related to mutation the re-injecting a mutated value
  • Bring back the skipped test
  • Use masks from palette-mobile Input component feat: support masks palette-mobile#240
Screen.Recording.2024-06-21.at.11.56.08.mov

Next step:

  • Update this phone input component so it can be used everywhere.

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • fix phone input component - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri self-assigned this Jun 21, 2024
@MounirDhahri MounirDhahri marked this pull request as ready for review June 21, 2024 10:51
@MounirDhahri MounirDhahri marked this pull request as draft June 21, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant