Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ArtistListItem): add accessibility props to the follow button #10703

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

fix(ArtistListItem): add accessibility props to the follow button #10703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/app/Components/ArtistListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,9 @@ const ArtistListItem: React.FC<Props> = ({
</Flex>
{!!showFollowButton && (
<Flex>
<FollowButton haptic isFollowed={!!is_followed} onPress={handleFollowArtist} />
<FollowButton haptic isFollowed={!!is_followed} onPress={handleFollowArtist}
accessibilityLabel={is_followed ? "Unfollow " + name : "Follow " + name}
accessibilityRole="button" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use role instead of accessibilityRole and for the label the RN community is moving towards aria props, so let's use aria-label instead 👍

Comment on lines +173 to +174
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @araujobarret, lets change that to what he suggested and ready to merge! Thanks for the contribution 😄

Suggested change
accessibilityLabel={is_followed ? "Unfollow " + name : "Follow " + name}
accessibilityRole="button" />
aria-label={is_followed ? "Unfollow " + name : "Follow " + name}
role="button"
/>

</Flex>
)}
</Flex>
Expand Down