Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DIA-899): One-Shot Google Sign-In #11036

Merged
merged 6 commits into from
Nov 4, 2024
Merged

feat(DIA-899): One-Shot Google Sign-In #11036

merged 6 commits into from
Nov 4, 2024

Conversation

iskounen
Copy link
Contributor

@iskounen iskounen commented Oct 29, 2024 •
edited
Loading

This PR resolves DIA-899

Description

  • Adds a new method for Google Sign-In that the auth2 flow uses to authenticate in one-shot (sign-up and login together)
  • Displays a loading screen while Google Sign-In is doing its thing
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2024-11-01.at.08.20.41.mp4

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • Implement one-shot Google Sign-In for auth2 - iskounen
  • Display a loading screen during Google Sign-in for auth2 - iskounen

Need help with something? Have a look at our docs, or get in touch with us.

@iskounen iskounen self-assigned this Oct 29, 2024
@iskounen iskounen marked this pull request as draft October 29, 2024 21:08
@iskounen iskounen force-pushed the iskounen/feat/one-shot-google-signin branch from cc14038 to fdce6d4 Compare October 30, 2024 18:13
@iskounen iskounen marked this pull request as ready for review November 1, 2024 12:16
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Nov 1, 2024 •
edited
Loading

This PR contains the following changes:

  • Dev changes (Implement one-shot Google Sign-In for auth2 - iskounen,Display a loading screen during Google Sign-in for auth2 - iskounen - iskounen)

Generated by 🚫 dangerJS against 94f4bc6

@iskounen iskounen requested a review from brainbicycle November 1, 2024 14:47
araujobarret
araujobarret previously approved these changes Nov 4, 2024
View reviewed changes
damassi
damassi reviewed Nov 4, 2024
View reviewed changes
src/app/store/AuthModel.ts Outdated Show resolved Hide resolved
damassi
damassi previously approved these changes Nov 4, 2024
View reviewed changes
brainbicycle
brainbicycle requested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@brainbicycle brainbicycle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Not sure if I am reading wrong but I think we may need some error handling for the google sign in ?

src/app/Scenes/Onboarding/Auth2/scenes/LoginWelcomeStep.tsx Outdated Show resolved Hide resolved
src/app/Scenes/Onboarding/Auth2/scenes/LoginWelcomeStep.tsx Outdated Show resolved Hide resolved
@iskounen iskounen dismissed stale reviews from damassi and araujobarret via 1a33827 November 4, 2024 18:31
brainbicycle
brainbicycle previously approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@brainbicycle brainbicycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks!

@iskounen iskounen force-pushed the iskounen/feat/one-shot-google-signin branch from 1a33827 to 94f4bc6 Compare November 4, 2024 21:24
@iskounen iskounen added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Nov 4, 2024
@artsy-peril artsy-peril bot merged commit 1e7328b into main Nov 4, 2024
7 checks passed
@artsy-peril artsy-peril bot deleted the iskounen/feat/one-shot-google-signin branch November 4, 2024 21:54
@iskounen iskounen mentioned this pull request Nov 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brainbicycle brainbicycle brainbicycle approved these changes

@damassi damassi damassi left review comments

@araujobarret araujobarret araujobarret left review comments

Assignees

@iskounen iskounen

Labels
Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iskounen @ArtsyOpenSource @damassi @araujobarret @brainbicycle